Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix SSL Context switching #3531

Merged
merged 4 commits into from
May 6, 2024
Merged

Conversation

pj892031
Copy link
Contributor

@pj892031 pj892031 commented May 3, 2024

Description

There is a use case when a service uses a ZAAS client and onboarding enabler together. The setup of the default SSL context factory could lead to a failing onboarding enabler.

step to reproduce:

  1. onboard by enabler (the connection fetched the default SSL context - using to detect if the SSL should be set - see the issue in Jersey)
  2. wait for at least 30 seconds - onboarding is working
  3. create a ZAAS client and try to call any endpoint (ie. login)
  4. onboarding started failing with 403 (default SSL context changed, ZAAS client stopped using client certificate)

The issue happened because of implementation in Jersey, see issue eclipse-ee4j/jersey#5637

Linked to # (issue)
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

Signed-off-by: Pavel Jares <[email protected]>
@pj892031 pj892031 requested a review from taban03 May 3, 2024 15:38
@pj892031 pj892031 marked this pull request as ready for review May 3, 2024 15:55
Signed-off-by: Pavel Jares <[email protected]>
@pull-request-size pull-request-size bot added size/M and removed size/S labels May 6, 2024
Signed-off-by: Pavel Jares <[email protected]>
Signed-off-by: Pavel Jares <[email protected]>
Copy link

sonarcloud bot commented May 6, 2024

@pj892031 pj892031 merged commit e7575f6 into v3.x.x May 6, 2024
31 checks passed
@delete-merged-branch delete-merged-branch bot deleted the reboot/v3-fix-default-ssl-context branch May 6, 2024 11:50
pj892031 added a commit that referenced this pull request May 6, 2024
@pj892031 pj892031 mentioned this pull request May 6, 2024
15 tasks
pj892031 added a commit that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants