Start Relay Resolver Docs with basic examples #480
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zth
approved these changes
Dec 12, 2023
Comment on lines
+43
to
+45
| * @onType User | ||
| * @fieldName greeting | ||
| * @rootFragment GreetingResolver |
There was a problem hiding this comment.
I think there's a more compact notation now that we could perhaps also show. Can't find a link to it now though.
|
I haven't tried passing JS arguments to resolvers in RescriptRelay yet myself. I would assume we need some deeper integration for that to work. |
|
Okay, I'll take that part out for now |
|
Superseded by recent doc updates. Thanks for the effort anyway! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created these based off the part of resolvers I have used. I tried to take a stab at graphql fragment arguments, but I have never had to use those so not sure if correct
I just used the
UserGreetingexample the relay docs used. We might want a more "rescripty" example that shows off how well resolvers work with Variants and switch statementTODO: