-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restoring event subscriptions code is faulty #3
Comments
Counter is not enough for detection subscription mismatch. |
yallie
added a commit
to yallie/Zyan
that referenced
this issue
Feb 18, 2019
yallie
added a commit
to yallie/Zyan
that referenced
this issue
Feb 18, 2019
yallie
added a commit
to yallie/Zyan
that referenced
this issue
Feb 18, 2019
yallie
added a commit
to yallie/Zyan
that referenced
this issue
Feb 18, 2019
TODO:
|
yallie
added a commit
to yallie/Zyan
that referenced
this issue
Feb 19, 2019
yallie
added a commit
to yallie/Zyan
that referenced
this issue
Feb 20, 2019
yallie
added a commit
that referenced
this issue
Feb 20, 2019
yallie
added a commit
to yallie/Zyan
that referenced
this issue
Feb 20, 2019
yallie
added a commit
to yallie/Zyan
that referenced
this issue
Feb 20, 2019
yallie
added a commit
to yallie/Zyan
that referenced
this issue
Feb 21, 2019
yallie
added a commit
to yallie/Zyan
that referenced
this issue
Feb 21, 2019
yallie
added a commit
to yallie/Zyan
that referenced
this issue
Feb 21, 2019
yallie
added a commit
to yallie/Zyan
that referenced
this issue
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Zyan currently uses subscription counters and checks if they match on client and server. But we can't rely on them if we're making concurrent calls with subscriptions/unsubscriptions. Zyan detects the mismatch and starts re-subscribing even if it actually doesn't need to. It doesn't break anything, just generates some parasite network traffic.
The text was updated successfully, but these errors were encountered: