-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: unique name filtering for call interceptors #79
Conversation
…nstead of equality check. More flexible way.
608b967
to
7158c00
Compare
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
==========================================
+ Coverage 68.46% 68.63% +0.16%
==========================================
Files 297 297
Lines 22488 22639 +151
Branches 1952 1978 +26
==========================================
+ Hits 15397 15538 +141
- Misses 6271 6273 +2
- Partials 820 828 +8
Continue to review full report at Codecov.
|
Hi Mikel, looks great! 👍 |
Hello, Alexey! Seems ok now, all tests passing and by-default interception performance not changed. I am using both bug fixing and name filtering in production already. Таки будем посмотреть) Yep it is ready |
Great! Thanks a lot :) |
You are welcome 👍 |
Hello guys:
Found and fixed a strange behavior when call interception mechanics works perfect with unnamed services but always failing for named services. Down there is slightly modified test code to reproduce the problem:
Also implemented name filtering feature for CallInterceptor to specify unique via regex not by just equality compare to make interceptor declaration more flexible: