Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add codespell workflow for CI #443

Merged
merged 8 commits into from
Apr 26, 2024
Merged

Conversation

xiaolou86
Copy link
Contributor

@xiaolou86 xiaolou86 commented Apr 25, 2024

Closes #258

Usage related changes

None

Development related changes

Add codespell check workflow for CI

Checklist:

  • Checked the relevant parts of development docs
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
  • Updated the docs if needed, including the TODO section
  • Linked the issues which this PR resolves
  • Updated the tests if needed; all passing (execution info)

@FabijanC FabijanC self-requested a review April 25, 2024 08:10
@FabijanC
Copy link
Contributor

I added a commit hoping that it would trigger CI, it didn't, I'll try something else, stay tuned

@xiaolou86
Copy link
Contributor Author

Is it because the PR comes from external forked repo?

_typos.toml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@FabijanC
Copy link
Contributor

I was able to trigger the workflow, it failed. Be sure to go through the checkboxes in your PR description and through my comments.

@xiaolou86
Copy link
Contributor Author

Got it, thank you for your quickly review!

@xiaolou86
Copy link
Contributor Author

I updated with the following changes:

  1. Use existing nightly toolchain instead of installing v1.75.0.
  2. Don't correct submodule typo.
  3. Use mock key to avoid typo error.

@FabijanC Please help me to review again. Thank you very much.

_typos.toml Outdated Show resolved Hide resolved
@FabijanC FabijanC merged commit 1ffe864 into 0xSpaceShard:main Apr 26, 2024
@xiaolou86
Copy link
Contributor Author

@FabijanC nice discussion and work happily with you. Thank you very much!

@FabijanC FabijanC mentioned this pull request Apr 26, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add codespell linter workflow for CI
2 participants