Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code spell check #447

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Improve code spell check #447

merged 2 commits into from
Apr 26, 2024

Conversation

FabijanC
Copy link
Contributor

@FabijanC FabijanC commented Apr 26, 2024

Usage related changes

  • None

Development related changes

  • Improve after feat: add codespell workflow for CI #443
  • Spelling check (installation and execution) is now a script in scripts/ which is used in .circleci/config.yml and can be used locally (e.g. in pre-commit)
  • Add .git/hooks/pre-commit notice to README.md

Checklist:

  • Checked the relevant parts of development docs
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
  • Updated the docs if needed, including the TODO section
  • Linked the issues which this PR resolves
  • Updated the tests if needed; all passing (execution info)

@FabijanC FabijanC merged commit 543374d into main Apr 26, 2024
@FabijanC FabijanC deleted the improve-code-spell-check branch April 26, 2024 09:38
@xiaolou86
Copy link
Contributor

wonderful improvement 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants