Proposed fix for pystring include paths #1900
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make Findpystring.cmake return the full include directory to pystring so that prefixing includes with "pystring/" is no longer required. Signed-off-by: Ingmar Rieger <[email protected]>
|
3 tasks
|
Good to see. Will close this and comment with some feedback on your Pull request. |
|
Added a comment to remia#52 as the current state wouldn't build on Arch Linux but otherwise it contains the changes as proposed here. |
|
Hi @irieger, I don't see your comment, can you double check you published it? Thanks for looking into it. |
|
New to those github workflows. Just sent the review. Hadn't realised I need to push another button. Gitlab which is my day to day tool has a much more prominent submit button ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Findpystring.cmake return the full include directory to pystring so that prefixing includes with "pystring/" is no longer required.
This changes the behaviour of the included Findpystring.cmake to match the bahaviour of other regular find_package modules to report the full include directory removing the requirement to use "pystring/" when including "pystring.h" etc.
(This follows from conan-io/conan-center-index#20703 (comment))