-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opencolorio 2.3.0, bump requirements #20703
Conversation
I detected other pull requests that are modifying opencolorio/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
@irieger |
You're welcome. Didn't want to steal your PR/contribution but just got a bit impatient waiting for anyone to react on your PR. Also let's see what CI says, I think your PR didn't build on the Conan 2 pipeline side (for 1.1.1). Not sure if it is expected for packages to support Conan 2 for all old versions? (I mean I'd prioritize having the newest version build on Conan 2 and maybe prevent regressions for old packages that build on Conan 2 before, but not enforce old builds?) |
This comment has been minimized.
This comment has been minimized.
Hey @conan-io/barbarians Also as I haven't got any meaningful feedback, is a PR normally only looked at when it is passing CI? This would be the problem for quite a few projects I assume where older versions might not be easily portable nor needed for projects using a current Conan, but where maybe for backwards compatibility it would be nice to keep old version? (I don't see the point of removing the old versions besides pleasing the CI?) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @irieger
Thank you so much for this PR. It looks great! 😄 Only a doubt about the patches.
Conan v1 pipeline ✔️All green in build 6 (
Conan v2 pipeline ✔️
All green in build 6 ( |
Specify library name and version: opencolorio/*
Version bump and dependency bump
Based on #19549 which started the work but so far the contributor hasn't answered. As I need the dependency updated and would prefer to directly also use the new version in a library that requires OpenColorIO, I want to move this forward.