Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opencolorio 2.3.0, bump requirements #20703

Merged
merged 13 commits into from
Nov 13, 2023

Conversation

irieger
Copy link
Contributor

@irieger irieger commented Oct 20, 2023

Specify library name and version: opencolorio/*

Version bump and dependency bump

Based on #19549 which started the work but so far the contributor hasn't answered. As I need the dependency updated and would prefer to directly also use the new version in a library that requires OpenColorIO, I want to move this forward.


@ghost
Copy link

ghost commented Oct 20, 2023

I detected other pull requests that are modifying opencolorio/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@toge
Copy link
Contributor

toge commented Oct 20, 2023

@irieger
Thanks you for contribution!
I will close my PR.

@irieger irieger changed the title Opencolorio 2.3.0 Opencolorio 2.3.0, bump requirements Oct 20, 2023
@irieger
Copy link
Contributor Author

irieger commented Oct 20, 2023

@irieger Thanks you for contribution! I will close my PR.

You're welcome. Didn't want to steal your PR/contribution but just got a bit impatient waiting for anyone to react on your PR. Also let's see what CI says, I think your PR didn't build on the Conan 2 pipeline side (for 1.1.1).

Not sure if it is expected for packages to support Conan 2 for all old versions? (I mean I'd prioritize having the newest version build on Conan 2 and maybe prevent regressions for old packages that build on Conan 2 before, but not enforce old builds?)

@conan-center-bot

This comment has been minimized.

@irieger
Copy link
Contributor Author

irieger commented Oct 21, 2023

Hey @conan-io/barbarians
what is the way forward with this? The Conan 2.0 pipeline fails for one version (and the canceled one would fail too). But that would be the same for the current state of the repository, as OpenColorIO before version 2.2.0 required openexr < 3 and openexr is only building on conan 2 from version 3.

Also as I haven't got any meaningful feedback, is a PR normally only looked at when it is passing CI? This would be the problem for quite a few projects I assume where older versions might not be easily portable nor needed for projects using a current Conan, but where maybe for backwards compatibility it would be nice to keep old version? (I don't see the point of removing the old versions besides pleasing the CI?)

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @irieger

Thank you so much for this PR. It looks great! 😄 Only a doubt about the patches.

recipes/opencolorio/all/conandata.yml Outdated Show resolved Hide resolved
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 6 (468043d40bfa3da814987a6676b99e8eff4daed1):

  • opencolorio/2.2.1:
    All packages built successfully! (All logs)

  • opencolorio/2.1.0:
    All packages built successfully! (All logs)

  • opencolorio/1.1.1:
    All packages built successfully! (All logs)

  • opencolorio/2.3.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 6 (468043d40bfa3da814987a6676b99e8eff4daed1):

  • opencolorio/2.2.1:
    All packages built successfully! (All logs)

  • opencolorio/2.1.0:
    All packages built successfully! (All logs)

  • opencolorio/1.1.1:
    All packages built successfully! (All logs)

  • opencolorio/2.3.0:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit bcfb212 into conan-io:master Nov 13, 2023
28 checks passed
@irieger irieger deleted the opencolorio-2.3.0 branch November 13, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants