-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ocioview image and PySide6 updates #1912
ocioview image and PySide6 updates #1912
Conversation
Signed-off-by: Michael Dolan <[email protected]>
Signed-off-by: Michael Dolan <[email protected]>
Signed-off-by: Michael Dolan <[email protected]>
…nColorIO into feature/ocioview_3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the issue @michdolan, looks good to me and confirm it works fine on mac OS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only a minor comment about maybe using properties in the MessageRouter
class.
def image_updates_allowed(self) -> bool: | ||
return self._image_updates_allowed | ||
|
||
def set_image_updates_allowed(self, allowed: bool) -> None: | ||
self._image_updates_allowed = allowed | ||
if allowed and self._prev_image_array is not None: | ||
# Rebroadcast last image record | ||
message_queue.put_nowait(self._prev_image_array) | ||
|
||
def processor_updates_allowed(self) -> bool: | ||
return self._processor_updates_allowed | ||
|
||
def set_processor_updates_allowed(self, allowed: bool) -> None: | ||
self._processor_updates_allowed = allowed | ||
if allowed and self._prev_config is not None: | ||
# Rebroadcast last config record | ||
message_queue.put_nowait(self._prev_config) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we use properties here?
@property
def image_updates_allowed(self) -> bool:
return self._image_updates_allowed
@image_updates_allowed.setter
def image_updates_allowed(self, allowed: bool) -> None:
self._image_updates_allowed = allowed
if allowed and self._prev_image_array is not None:
# Rebroadcast last image record
message_queue.put_nowait(self._prev_image_array)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I will address this in a future PR
@michdolan , should we go ahead and merge this? |
@remia thoughts on the CI failure I'm getting since updating the base? It's related to CMake, but this work only changed Python files internal to |
I haven't time to investigate properly this week but it seems like the issue we have in #1964 ? I didn't see the error as the job was in canceled state today, I relaunched it and it now passes so this might have been fixed with a CMake update. |
This PR makes the following changes to
ocioview
: