-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ocioview updates & fixes #1966
ocioview updates & fixes #1966
Conversation
Signed-off-by: Michael Dolan <[email protected]>
Signed-off-by: Michael Dolan <[email protected]>
Signed-off-by: Michael Dolan <[email protected]>
Signed-off-by: Michael Dolan <[email protected]>
Signed-off-by: Michael Dolan <[email protected]>
Signed-off-by: Michael Dolan <[email protected]>
@@ -156,14 +169,19 @@ def start_routing(self) -> None: | |||
self._handle_config_message(msg_raw) | |||
|
|||
# OCIO processor | |||
elif isinstance(msg_raw, ocio.Processor): | |||
self._prev_cpu_proc = msg_raw | |||
elif ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels a bit "magical" :)
Might need a dedicated definition in the future to manage all those comparisons if we need to do it elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was talking about this block specifically:
isinstance(msg_raw, tuple)
and len(msg_raw) == 2
and isinstance(msg_raw[0], ProcessorContext)
and isinstance(msg_raw[1], ocio.Processor)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @michdolan, LGTM!
This PR makes a number of updates and improvements to
ocioview
:ProcessorContext
interface to reference input and output processor parameters so application components that receive a viewer's processor can inspect the config items that created it. This dataclass includes the processor's: input color space name, output transform item type, output transform item name, and transform direction. This should resolve questions raised in PR: ocioview - Chromaticities Inspector #1914 .