Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp8266: Syntax error at overwriting presets #3312

Closed
1 task done
reald opened this issue Aug 9, 2023 · 5 comments
Closed
1 task done

esp8266: Syntax error at overwriting presets #3312

reald opened this issue Aug 9, 2023 · 5 comments
Labels
bug needs investigation The bug has not yet been reproduced by me. Analysis or more details are needed. waiting for feedback addition information needed to better understand the issue

Comments

@reald
Copy link

reald commented Aug 9, 2023

What happened?

When updating a preset "SyntaxError: Expected ',' or '}' after property value in JSON at position 2226" appears.

To Reproduce Bug

A preset "Fire 2012" exists at position 3. After some modifications trieded to update the preset with following settings:

[x] Overwrite with state
[x] Include brightness
[x] Save segment bounds
[ ] Checked segments only
Save to ID 3

Expected Behavior

Preset is updated

Install Method

Self-Compiled

What version of WLED?

0.14.0-b3 "Hoshi"

Which microcontroller/board are you seeing the problem on?

ESP8266

Relevant log/trace output

No response

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@reald reald added the bug label Aug 9, 2023
@softhack007 softhack007 changed the title Syntax error at overwriting presets esp8266: Syntax error at overwriting presets Aug 9, 2023
@dosipod
Copy link

dosipod commented Aug 11, 2023

Factory reset the unit or flash the nightly builds , the error you see there could happen even with other effects but I can save Fire 2012 on my test unit just fine . You seeing that error with this effect is just a coincidence unless your Self-Compiled is messing things . I have seen this error more with ESP8266 builds when making a lot of presets but cant say what is the reason for it
image

@softhack007 softhack007 added this to the 0.14.0 candidate milestone Sep 6, 2023
@softhack007 softhack007 added the needs investigation The bug has not yet been reproduced by me. Analysis or more details are needed. label Sep 6, 2023
@softhack007
Copy link
Collaborator

softhack007 commented Sep 17, 2023

@blazoncek any idea on this one?

Same as @dosipod, I have saved lots of presets with default options, however usually doing it on esp32 as I only have one 8266, which is reserved for collecting dust 😉 on my high cupboard. Could there be something causing errors on 8266, while it works on esp32?

@blazoncek
Copy link
Collaborator

This is related to AsyncWebServer buffer being corrupt. Refreshing UI will often resolve the problem.
My speculation is that at some point buffer pointer is being released too soon in async call.
Or that send buffer gets overwritten by incoming traffic.

blazoncek added a commit that referenced this issue Oct 22, 2023
blazoncek added a commit that referenced this issue Oct 22, 2023
@softhack007 softhack007 added the waiting for feedback addition information needed to better understand the issue label Dec 14, 2023
@blazoncek
Copy link
Collaborator

Possibly related to #3641

@blazoncek
Copy link
Collaborator

Closing as corrupt JSON has been fixed in 0.14.1-b3.
If the issue persist in 0.14.1-b3 or later, please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs investigation The bug has not yet been reproduced by me. Analysis or more details are needed. waiting for feedback addition information needed to better understand the issue
Projects
None yet
Development

No branches or pull requests

4 participants