Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jumping of selected effect on refresh #3466

Merged
merged 4 commits into from
Oct 22, 2023

Conversation

w00000dy
Copy link
Contributor

Hi!
This fixes the problem that the selected effect jumps to the bottom and back on a refresh.

For example, if you select the effect rainbow and there is a refresh, it jumps from this:
grafik
To this:
grafik
And then back.

To reproduce this, just select the rainbow effect, go to Info and click on the refresh button a few times. Then you should see it in the background.

fix effect jumping on refresh

fix jumping of selected effect on refresh
@blazoncek
Copy link
Collaborator

Thanks. Can you re-base this PR to 0_14_1 branch?

@blazoncek blazoncek added the javascript Pull requests that update Javascript code label Oct 21, 2023
@w00000dy w00000dy changed the base branch from main to 0_14_1 October 22, 2023 16:08
@w00000dy
Copy link
Contributor Author

Done

@blazoncek blazoncek merged commit 3eabefd into Aircoookie:0_14_1 Oct 22, 2023
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants