Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jumping of selected effect on refresh #3466

Merged
merged 4 commits into from
Oct 22, 2023
Merged

Fix jumping of selected effect on refresh #3466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c7d399c
fix effect jumping on refresh
w00000dy Oct 20, 2023
0b28107
Merge branch 'fix-effect-jumping' into 0_14_1
w00000dy Oct 22, 2023
94dc611
Merge pull request #1 from WoodyLetsCode/0_14_1
w00000dy Oct 22, 2023
7ff6a6e
updated html_ui.h via npm run build
w00000dy Oct 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions wled00/data/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1513,12 +1513,15 @@ function setEffectParameters(idx)
}

// set the bottom position of selected effect (sticky) as the top of sliders div
setInterval(()=>{
function setSelectedEffectPosition() {
let top = parseInt(getComputedStyle(gId("sliders")).height);
top += 5;
let sel = d.querySelector('#fxlist .selected');
if (sel) sel.style.bottom = top + "px"; // we will need to remove this when unselected (in setFX())
},750);
}

setSelectedEffectPosition();
setInterval(setSelectedEffectPosition,750);
// set html color items on/off
var cslLabel = '';
var sep = '';
Expand Down
Loading
Loading