Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate styles to ControlThemes #233

Closed
28 tasks done
SKProCH opened this issue May 21, 2023 · 4 comments
Closed
28 tasks done

Migrate styles to ControlThemes #233

SKProCH opened this issue May 21, 2023 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed up for grabs You can submit PR with implementation
Milestone
v3.0.0

Comments

@SKProCH
Copy link
Collaborator

SKProCH commented May 21, 2023 •
edited by JanTamis
Loading

Before full 3.0.0 release we need to migrate all remaining Styles to ControlThemes.
There is no much more left:

  • RepeatButton.xaml
  • AutoCompleteBox.xaml
  • CalendarButton.xaml
  • CalendarDayButton.xaml
  • CalendarItem.xaml
  • Carousel.xaml
  • ComboBox.xaml
  • ComboBoxItem.xaml
  • ContentControl.xaml
  • ContentExpandControl.axaml
  • ContextMenu.xaml
  • EmbeddableControlRoot.xaml
  • FlyoutPresenter.axaml
  • GridSplitter.xaml
  • Menu.xaml
  • MenuItem.xaml
  • NativeMenuBar.xaml
  • NotificationCard.xaml
  • NumericUpDown.xaml
  • OverlayPopupHost.xaml
  • PopupRoot.xaml
  • Separator.xaml
  • SplitView.xaml
  • ToolTip.xaml
  • WindowNotificationManager.xaml
  • SideSheet.xaml
  • TransitioningContentControl.axaml
  • Calendar.xaml

New files should be created in Resources/Themes folder and imported in MaterialToolKit.xaml.
All PRs and support are highly appreciated.
@SKProCH SKProCH added enhancement New feature or request up for grabs You can submit PR with implementation labels May 21, 2023
@SKProCH SKProCH pinned this issue May 21, 2023
@SKProCH SKProCH added the help wanted Extra attention is needed label May 21, 2023
SKProCH added a commit that referenced this issue May 31, 2023
@SKProCH
Migrate another bunch of styles to ControlTheme #233
d68f18a
@SKProCH
Copy link
Collaborator Author

SKProCH commented Jun 15, 2023

Some of the styles implemented via #239
Thanks, @JanTamis

@JanTamis
Copy link
Collaborator

JanTamis commented Jul 13, 2023 •
edited
Loading

@SKProCH so the combobox doesnt work. is this because it is not yet migrated to a controltheme?

@SKProCH
Copy link
Collaborator Author

SKProCH commented Jul 13, 2023

Hello, @JanTamis
No, seems like this is a bug. Can you raise an issue, please?

@JanTamis
Copy link
Collaborator

JanTamis commented Jul 13, 2023 •
edited
Loading

yes see #264

@SKProCH SKProCH added this to the v3.0.0 milestone Jul 22, 2023
SKProCH added a commit that referenced this issue Jul 31, 2023
@SKProCH
Implement TimePicker style, TimePickerAssist. Fix some bugs in Clock.…
29fddf5 
… Add TimePicker in demo. Closes #253. #233
SKProCH added a commit that referenced this issue Jul 31, 2023
@SKProCH
Migrate Menu and MenuItem to ControlThemes. #233
2d53532
SKProCH added a commit that referenced this issue Jul 31, 2023
@SKProCH
Migrate ContextMenu to ControlThemes. #233
c63550e
@JanTamis JanTamis mentioned this issue Sep 1, 2023
Merged
@SKProCH SKProCH closed this as completed Sep 2, 2023
@SKProCH SKProCH unpinned this issue Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed up for grabs You can submit PR with implementation
Projects
None yet
Milestone
v3.0.0
Development

No branches or pull requests
2 participants
@SKProCH @JanTamis