Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ControlThemes #239

Conversation

JanTamis
Copy link
Collaborator

@JanTamis JanTamis commented Jun 5, 2023

If there are any tips let me know

@JanTamis JanTamis marked this pull request as draft June 5, 2023 17:18
@JanTamis JanTamis changed the title Updated AutoCompleteBox to use ControlThemes Update ControlThemes Jun 5, 2023
@SKProCH
Copy link
Collaborator

SKProCH commented Jun 5, 2023

Can you please reformat files before commit? Repository contains .editorconfig file, so rider will be automatically format everything properly.

@JanTamis
Copy link
Collaborator Author

JanTamis commented Jun 5, 2023

is this what you meant?

@SKProCH
Copy link
Collaborator

SKProCH commented Jun 5, 2023

Oh, sorry for my misinformation, I was only referring to the files you're working on. You don't need to format the whole project, of course. Do you know how to roll back commits?

@JanTamis
Copy link
Collaborator Author

JanTamis commented Jun 5, 2023

i will take a look

@JanTamis
Copy link
Collaborator Author

JanTamis commented Jun 5, 2023

is it correct now?

@SKProCH
Copy link
Collaborator

SKProCH commented Jun 5, 2023

Yep, seems like everything right

@JanTamis
Copy link
Collaborator Author

JanTamis commented Jun 6, 2023

@SKProCH have I broke something?

@SKProCH
Copy link
Collaborator

SKProCH commented Jun 6, 2023

What do you mean?

@JanTamis
Copy link
Collaborator Author

JanTamis commented Jun 6, 2023

well I did a rebase and I saw some commits appeared so I was afraid I broke something

@SKProCH
Copy link
Collaborator

SKProCH commented Jun 6, 2023

This is kinda strange, but looks like fine now.

@SKProCH
Copy link
Collaborator

SKProCH commented Jun 14, 2023

Hello, @JanTamis

What's left to do?

@JanTamis
Copy link
Collaborator Author

Hello, @SKProCH

The following styles are left:

  • ComboBox
  • ComboBoxItem
  • ContextMenu
  • FlyoutPresenter
  • FocusAdorner
  • Menu
  • MenuItem
  • UserControl (i had problems implementing this)

@SKProCH
Copy link
Collaborator

SKProCH commented Jun 15, 2023

If you have a problems with something feel free to just skip it. We actually can merge current PR if you want, and after that you can add something via separate PRs.

@JanTamis
Copy link
Collaborator Author

I'm fine with that.

@JanTamis JanTamis marked this pull request as ready for review June 15, 2023 11:44
@SKProCH SKProCH self-requested a review June 15, 2023 14:29
Material.Demo/Program.cs Outdated Show resolved Hide resolved
Material.Styles/Resources/Themes/AutoCompleteBox.axaml Outdated Show resolved Hide resolved
Material.Styles/Resources/Themes/AutoCompleteBox.axaml Outdated Show resolved Hide resolved
@SKProCH SKProCH merged commit 77ea46c into AvaloniaCommunity:3.0_major_update Jun 15, 2023
@SKProCH
Copy link
Collaborator

SKProCH commented Jun 15, 2023

Thanks for your help, @JanTamis

I really appreciate your help.

@SKProCH SKProCH mentioned this pull request Jun 15, 2023
28 tasks
@JanTamis
Copy link
Collaborator Author

I'm happy to help :)

@JanTamis JanTamis deleted the 3.0_major_update_ControlTheme branch June 19, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants