[Core] Redo: Use WAM as the default authentication method on Windows #28841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the May 2024 (2024-05-21)❗ Breaking change release ❗ milestone
️✔️AzureCLI-BreakingChangeTest
|
|
Use WAM as the default authentication |
microsoft-github-policy-service
bot
requested review from
zhoxing-ms and
yonzhan
microsoft-github-policy-service
bot
added
the
ARM
microsoft-github-policy-service
bot
added
Account
|
Should we add instruction for disabling WAM in the warning message? azure-cli/src/azure-cli-core/azure/cli/core/auth/identity.py Lines 152 to 153 in 246725e |
rayluo
approved these changes
Apr 26, 2024
Comment on lines
-26
to
-31
| <p>You may opt-in to use WAM by running the following commands:</p> | ||
| <code> | ||
| az config set core.enable_broker_on_windows=true<br> | ||
| az account clear<br> | ||
| az login | ||
| </code> |
There was a problem hiding this comment.
I think you can remove only the outdated "Announcements" but still keep the "you may opt-in ..." part.
There was a problem hiding this comment.
This is no longer "opt-in", but "enable". @dcaro for the wording.
There was a problem hiding this comment.
@jiasli this page will only be displayed when user login using the web browser flow. With WAM being the default on Windows and not supported on other OS, we do not need to have content about WAM in this page.
Situation 1: User is on Windows and has this page, they have disabled WAM so they are aware of it.
Situation 2: User is on Other OS, there is no reason to communicate about WAM.
There was a problem hiding this comment.
Totally agree. That's why I remove it.
dcaro
approved these changes
May 7, 2024
evelyn-ys
approved these changes
May 7, 2024
bebound
approved these changes
May 7, 2024
|
The help message should also be updated: |
This was referenced May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo #28085
Related command
az loginDescription
After previewing WAM for over a year (#23828), we now use WAM as the default authentication method on Windows.
If you encounter any issue and want to revert to the previous browser-based authentication method, run the following script:
Testing Guide
History Notes
[Core] BREAKING CHANGE:
az login: Use WAM as the default authentication method on Windows. For more details, see https://go.microsoft.com/fwlink/?linkid=2271136