{Core} Update WAM-related messages #28994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
refine WAM-related messages |
microsoft-github-policy-service
bot
added
Account
jiasli
commented
May 21, 2024
yonzhan
previously approved these changes
May 21, 2024
bebound
previously approved these changes
May 22, 2024
jiasli
commented
May 22, 2024
Comment on lines
15
to
16
| Windows systems use Web Account Manager (WAM), and Linux and macOS systems use browser-based login by default. | ||
| If WAM or a web browser is not available, CLI will fall back to device code login. |
There was a problem hiding this comment.
This is to address #28841 (comment).
I copied the text from https://learn.microsoft.com/en-us/cli/azure/authenticate-azure-cli-interactively#interactive-login
Perhaps we can use
Suggested change
| Windows systems use Web Account Manager (WAM), and Linux and macOS systems use browser-based login by default. | |
| If WAM or a web browser is not available, CLI will fall back to device code login. | |
| Azure CLI uses Web Account Manager (WAM) on Windows, and browser-based login on Linux and macOS by default. | |
| If WAM or a web browser is not available, Azure CLI will fall back to device code login. |
There was a problem hiding this comment.
One thing, @jiasli, there are many "CLIs" at Microsoft. Granted, if a customer is receiving this message in-line, we are obviously talking about "Azure CLI", but just letting you know that in docs, I always use the full name. I also have a quality remediation work item to change this in TOCs and other docs that talk about our product. No update requested. Just communicating.
There was a problem hiding this comment.
I have changed "CLI" to "Azure CLI" to be explicit.
@dbradish-microsoft, which statement do you prefer?
Windows systems use Web Account Manager (WAM), and Linux and macOS systems use browser-based login by default. If WAM or a web browser is not available, CLI will fall back to device code login.
or
Azure CLI uses Web Account Manager (WAM) on Windows, and browser-based login on Linux and macOS by default. If WAM or a web browser is not available, Azure CLI will fall back to device code login.
There was a problem hiding this comment.
@jiasli, definitely the 2nd sentence.
jiasli
changed the title
jiasli
commented
May 22, 2024
jiasli
commented
Jun 6, 2024
| @@ -29,6 +29,9 @@ | |||
| AZURE_CLIENT_ID = "AZURE_CLIENT_ID" | |||
| AZURE_CLIENT_SECRET = "AZURE_CLIENT_SECRET" | |||
|
|
|||
| WAM_PROMPT = ( | |||
| "Please select the account you want to log in with. " | |||
There was a problem hiding this comment.
Removing "Please" as suggested by @dbradish-microsoft:
In docs, they also don't like us to use "please"
Suggested change
| "Please select the account you want to log in with. " | |
| "Select the account you want to log in with. " |
bebound
previously approved these changes
Jun 17, 2024
bebound
approved these changes
Jun 24, 2024
evelyn-ys
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az loginDescription
Fix #28841 (comment)
Update the WAM prompt message after making WAM the default authentication method on Windows (#28841). This information is already in the history notes of #28841.
Testing Guide
az login