-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved handling of env reload request - handles older version of worker sdk #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyju
commented
Oct 10, 2023
host/src/FunctionsNetHost/Grpc/WorkerConfig/WorkerDescription.cs
Outdated
Show resolved
Hide resolved
7 tasks
satvu
approved these changes
Oct 10, 2023
host/src/FunctionsNetHost/Grpc/WorkerConfig/WorkerConfigUtils.cs
Outdated
Show resolved
Hide resolved
jviau
approved these changes
Oct 10, 2023
host/src/FunctionsNetHost/Grpc/Exceptions/EnvironmentReloadUnsupportedException.cs
Outdated
Show resolved
Hide resolved
host/src/FunctionsNetHost/Grpc/WorkerConfig/WorkerConfigUtils.cs
Outdated
Show resolved
Hide resolved
Switched to async overload for deserialization. Updated global.json to use rc2
brettsam
approved these changes
Oct 11, 2023
host/src/FunctionsNetHost/Grpc/Exceptions/EnvironmentReloadUnsupportedException.cs
Outdated
Show resolved
Hide resolved
host/src/FunctionsNetHost/Grpc/WorkerConfig/WorkerDescription.cs
Outdated
Show resolved
Hide resolved
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating native placeholder to handle specialization request for function app payload which has older version worker package.
We will be updating the worker.sdk package to include a new property called
"isSpecializable"canUsePlaceholder
the "worker.config.json". The native placeholder will look for this property and if not present, it will the environment reload response with "failure" as status and a special exception. On the host we will check the exception associated with the failed env reload response and if it is this special exception. we will execute the fallback code - which is to shut down this channel and start a new channel with the customer payload dll.For reference - the host changes are going to look like this: Azure/azure-functions-host#9602 - This is the host version I used to test my changes locally.
Pull request checklist
release_notes.md
Additional information
Additional PR information