Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved handling of env reload request - handles older version of worker sdk #1955

Merged
merged 6 commits into from
Oct 11, 2023

Conversation

kshyju
Copy link
Member

@kshyju kshyju commented Oct 10, 2023

Updating native placeholder to handle specialization request for function app payload which has older version worker package.

We will be updating the worker.sdk package to include a new property called "isSpecializable" canUsePlaceholder the "worker.config.json". The native placeholder will look for this property and if not present, it will the environment reload response with "failure" as status and a special exception. On the host we will check the exception associated with the failed env reload response and if it is this special exception. we will execute the fallback code - which is to shut down this channel and start a new channel with the customer payload dll.

For reference - the host changes are going to look like this: Azure/azure-functions-host#9602 - This is the host version I used to test my changes locally.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

Switched to async overload for deserialization.
Updated global.json to use rc2
@mattchenderson mattchenderson added the perf: cold-start Tracking performance items related to cold start label Oct 11, 2023
@mattchenderson mattchenderson linked an issue Oct 11, 2023 that may be closed by this pull request
@kshyju kshyju merged commit da4e1f2 into main Oct 11, 2023
25 checks passed
@kshyju kshyju deleted the shkr/check_worker_version_in_nativeplaceholder branch October 11, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf: cold-start Tracking performance items related to cold start
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent placeholder attempts with older versions of the SDK
5 participants