Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including "canUsePlaceholder" property in worker.config #1956

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

kshyju
Copy link
Member

@kshyju kshyju commented Oct 10, 2023

Part of #1951 fix

Including canUsePlaceholder property in worker.config. This property will be used by native placeholder to determine whether the function app payload uses a new version of worker package or not.

We will be publishing a new version with this change and update our docs suggesting customers to use this version as the minimum version to get placeholder support.

Native placeholder changes to read this property is in #1955

Pull request checklist

  • My changes do not require documentation changes - I will work with @mattchenderson to update the docs once our changes are out and validated.
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@mattchenderson mattchenderson added the perf: cold-start Tracking performance items related to cold start label Oct 11, 2023
@kshyju kshyju changed the title Including "isSpecializable" property in worker.config Including "canUsePlaceholder" property in worker.config Oct 11, 2023
@kshyju kshyju force-pushed the shkr/include_isspecializable_prop_in_worker_config branch from 20276f3 to 089f0b5 Compare October 11, 2023 18:16
@kshyju kshyju marked this pull request as ready for review October 11, 2023 18:40
@surgupta-msft
Copy link
Contributor

Would be good to have a documentation issue created and linked for tracking. Also, any plans to add details about these changes (in host and worker) in engineering docs?

@kshyju
Copy link
Member Author

kshyju commented Oct 11, 2023

Would be good to have a documentation issue created and linked for tracking. Also, any plans to add details about these changes (in host and worker) in engineering docs?

For this specific change, there won't be docs update as this is not something customers needs to be aware of. No plans to update eng docs for the related host change at this point. but may consider including this in the placeholder wiki thing I am planning.

@kshyju kshyju merged commit a70ead9 into main Oct 11, 2023
24 checks passed
@kshyju kshyju deleted the shkr/include_isspecializable_prop_in_worker_config branch October 11, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf: cold-start Tracking performance items related to cold start
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants