Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Fix] Parse HTTP result bindings in legacy generator #2342

Merged
merged 19 commits into from
Apr 11, 2024
Merged

[Bug Fix] Parse HTTP result bindings in legacy generator #2342

merged 19 commits into from
Apr 11, 2024

Conversation

satvu
Copy link
Member

@satvu satvu commented Mar 11, 2024

Issue describing the changes in this PR

Follow up to #2322 with fix for legacy generator.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@satvu satvu changed the title Satvu/legacy generator http [Bug Fix] Parse HTTP result bindings in legacy generator Mar 11, 2024
Base automatically changed from satvu/poco-return-metadata to main April 5, 2024 20:54
@satvu satvu force-pushed the satvu/legacy-generator-http branch from e1d4ac3 to 4a2d70a Compare April 5, 2024 21:08
@satvu satvu marked this pull request as ready for review April 5, 2024 21:18
@satvu satvu requested a review from kshyju April 9, 2024 18:20
@satvu satvu requested a review from liliankasem April 9, 2024 18:20
@satvu satvu merged commit 3a9a560 into main Apr 11, 2024
22 checks passed
@satvu satvu deleted the satvu/legacy-generator-http branch April 11, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kshyju kshyju kshyju approved these changes

@liliankasem liliankasem liliankasem approved these changes

@jviau jviau Awaiting requested review from jviau

@brettsam brettsam Awaiting requested review from brettsam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@satvu @kshyju @liliankasem