-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG FIX] HTTP Trigger Functions with Multiple Output Bindings #2322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main request is for changes to the sample so it can be leveraged in the docs.
sdk/Sdk.Generators/FunctionMetadataProviderGenerator/KnownFunctionMetadataTypes.cs
Outdated
Show resolved
Hide resolved
...Sdk.Generators/FunctionMetadataProviderGenerator/FunctionMetadataProviderGenerator.Parser.cs
Outdated
Show resolved
Hide resolved
...Sdk.Generators/FunctionMetadataProviderGenerator/FunctionMetadataProviderGenerator.Parser.cs
Outdated
Show resolved
Hide resolved
...Generator.Tests/FunctionMetadataProviderGeneratorTests/IntegratedTriggersAndBindingsTests.cs
Outdated
Show resolved
Hide resolved
...Sdk.Generators/FunctionMetadataProviderGenerator/FunctionMetadataProviderGenerator.Parser.cs
Show resolved
Hide resolved
Just confirming - the sample changes have been dropped from this PR, correct? For docs, should I plan on an inline revision then? |
For now, yes - the sample with the docsnippet will be added after the SDK is released and we can update the sample app reference. |
...Worker.Extensions.Http.AspNetCore/src/FunctionsMiddleware/FunctionsHttpProxyingMiddleware.cs
Outdated
Show resolved
Hide resolved
...Worker.Extensions.Http.AspNetCore/src/FunctionsMiddleware/FunctionsHttpProxyingMiddleware.cs
Outdated
Show resolved
Hide resolved
...Worker.Extensions.Http.AspNetCore/src/FunctionsMiddleware/FunctionsHttpProxyingMiddleware.cs
Outdated
Show resolved
Hide resolved
...Worker.Extensions.Http.AspNetCore/src/FunctionsMiddleware/FunctionsHttpProxyingMiddleware.cs
Outdated
Show resolved
Hide resolved
test/DotNetWorkerTests/AspNetCore/FunctionsHttpProxyingMiddlewareTests.cs
Outdated
Show resolved
Hide resolved
test/DotNetWorkerTests/AspNetCore/FunctionsHttpProxyingMiddlewareTests.cs
Outdated
Show resolved
Hide resolved
...Sdk.Generators/FunctionMetadataProviderGenerator/FunctionMetadataProviderGenerator.Parser.cs
Outdated
Show resolved
Hide resolved
...Sdk.Generators/FunctionMetadataProviderGenerator/FunctionMetadataProviderGenerator.Parser.cs
Outdated
Show resolved
Hide resolved
...Sdk.Generators/FunctionMetadataProviderGenerator/FunctionMetadataProviderGenerator.Parser.cs
Outdated
Show resolved
Hide resolved
...Worker.Extensions.Http.AspNetCore/src/FunctionsMiddleware/FunctionsHttpProxyingMiddleware.cs
Outdated
Show resolved
Hide resolved
I've also pushed some changes to the middleware to help with some of the issues. Done a bit quickly, so the tests mentioned and a review, would be good. |
a6b8ad1
to
1eb9789
Compare
...Generator.Tests/FunctionMetadataProviderGeneratorTests/IntegratedTriggersAndBindingsTests.cs
Show resolved
Hide resolved
...Worker.Extensions.Http.AspNetCore/src/FunctionsMiddleware/FunctionsHttpProxyingMiddleware.cs
Show resolved
Hide resolved
test/DotNetWorkerTests/AspNetCore/FunctionsHttpProxyingMiddlewareTests.cs
Show resolved
Hide resolved
…/azure-functions-dotnet-worker into satvu/poco-return-metadata
Issue describing the changes in this PR
resolves #2079
Pull request checklist
release_notes.md
Additional information
Currently, function metadata generation in both legacy and source-generation have special handling of
HttpResponseData
types in multiple output binding scenarios. Neither of these generators handle new types introduced in ASP.NET Core Integration (likeIActionResult
).This PR introduces the following features:
HttpResponseOutputAttribute
TryGetHttpResponse<T>
$return
binding and has to be searched for inside of the output bindings list instead).Not included: