Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Source-Gen][Bug Fix] Array input in SignalR generated correctly #2344

Merged
merged 16 commits into from
Apr 19, 2024
Merged

[Source-Gen][Bug Fix] Array input in SignalR generated correctly #2344

merged 16 commits into from
Apr 19, 2024

Conversation

satvu
Copy link
Member

@satvu satvu commented Mar 11, 2024 •
edited
Loading

Issue describing the changes in this PR

Will go in after #2322 which has test structure refactoring that this PR depends on, resolves #2100

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@satvu satvu linked an issue Mar 11, 2024 that may be closed by this pull request
Isolated functions with .NET 8 - SignalR extension throws warning CS8785 #2100
Closed
Base automatically changed from satvu/poco-return-metadata to main April 5, 2024 20:54
@satvu satvu force-pushed the satvu/sourcegen-array-error branch from 5aaa549 to 5db39aa Compare April 5, 2024 21:36
@satvu satvu marked this pull request as ready for review April 12, 2024 21:55
@satvu satvu requested a review from jviau April 12, 2024 21:56
@satvu satvu requested a review from kshyju April 16, 2024 22:18
@satvu satvu merged commit 1e81e61 into main Apr 19, 2024
22 checks passed
@satvu satvu deleted the satvu/sourcegen-array-error branch April 19, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kshyju kshyju kshyju approved these changes

@liliankasem liliankasem liliankasem approved these changes

@fabiocav fabiocav Awaiting requested review from fabiocav

@jviau jviau Awaiting requested review from jviau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Isolated functions with .NET 8 - SignalR extension throws warning CS8785
3 participants
@satvu @kshyju @liliankasem