Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prepend proxy sidecar container to prevent application container restarts #1102

Conversation

Sheludchenko
Copy link
Contributor

Reason for Change:
To fix application container startup errors due to incorrect container ordering (proxy sidecar will be triggered last instead of first).

Issue Fixed:
Fixes #1101

@Sheludchenko Sheludchenko changed the title Prepend proxy sidecar container to prevent application container restarts fix: Prepend proxy sidecar container to prevent application container restarts Aug 31, 2023
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

func TestInjectProxySidecarContainer(t *testing.T) {
needs to be modified to check the ordering and tests to pass.

@aramase
Copy link
Member

aramase commented Sep 8, 2023

Thank you for the PR! This comment has been included in #1108.

@aramase aramase closed this Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepend proxy sidecar to the container list to prevent application restarts
2 participants