fix: prepend proxy sidecar container to prevent application container restarts #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anish Ramasekar <[email protected]>
aramase
force-pushed
the
aramase/f/prepend-proxy-sidecar
branch
from
4504746
to
ce2b86d
Compare
Codecov Report
@@ Coverage Diff @@
## main #1108 +/- ##
=======================================
Coverage 55.49% 55.49%
=======================================
Files 36 36
Lines 2294 2294
=======================================
Hits 1273 1273
Misses 980 980
Partials 41 41
|
enj
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix application container startup errors due to incorrect container ordering (proxy sidecar will be triggered last instead of first).
fixes #1101
This PR builds on top of #1102 and fixes the unit tests.