Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add omitempty JSON tag to exportedSince field #142

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

michaelawyu
Copy link
Collaborator

What type of PR is this?

/kind bug
/kind api-change

What this PR does / why we need it:

This PR adds the omitempty JSON tag to the exportedSince optional field.

Which issue(s) this PR fixes:

N/A

Requirements:

How has this code been tested

N/A

Special notes for your reviewer

N/A

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #142 (0e0efe7) into main (2a56504) will increase coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
+ Coverage   78.46%   78.68%   +0.22%     
==========================================
  Files          20       20              
  Lines        2712     2712              
==========================================
+ Hits         2128     2134       +6     
+ Misses        463      459       -4     
+ Partials      121      119       -2     
Impacted Files Coverage Δ
pkg/controllers/hub/serviceimport/controller.go 72.85% <0.00%> (-4.29%) ⬇️
...ntrollers/member/endpointsliceimport/controller.go 79.92% <0.00%> (-2.37%) ⬇️
pkg/controllers/member/endpointslice/controller.go 76.97% <0.00%> (-1.44%) ⬇️
...ontrollers/hub/internalserviceimport/controller.go 77.38% <0.00%> (+1.58%) ⬆️
.../controllers/hub/endpointsliceexport/controller.go 72.76% <0.00%> (+2.98%) ⬆️
pkg/controllers/multiclusterservice/controller.go 83.83% <0.00%> (+3.36%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@michaelawyu michaelawyu merged commit c32220b into Azure:main Nov 1, 2022
@michaelawyu michaelawyu deleted the quickfix branch November 1, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants