Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add omitempty JSON tag to exportedSince field #142

Merged
merged 1 commit into from
Nov 1, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/v1alpha1/common_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ type ExportedObjectReference struct {
// The timestamp from a local clock when the generation of the object is exported.
// This field is marked as optional for backwards compatibility reasons.
// +kubebuilder:validation:Optional
ExportedSince metav1.Time `json:"exportedSince"`
ExportedSince metav1.Time `json:"exportedSince,omitempty"`
}

// FromMetaObjects builds a new ExportedObjectReference using TypeMeta and ObjectMeta fields from an object.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ spec:
exportedSince:
description: The timestamp from a local clock when the generation
of the object is exported. This field is marked as optional
for compatibility reasons.
for backwards compatibility reasons.
format: date-time
type: string
generation:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ spec:
exportedSince:
description: The timestamp from a local clock when the generation
of the object is exported. This field is marked as optional
for compatibility reasons.
for backwards compatibility reasons.
format: date-time
type: string
generation:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ spec:
exportedSince:
description: The timestamp from a local clock when the generation
of the object is exported. This field is marked as optional
for compatibility reasons.
for backwards compatibility reasons.
format: date-time
type: string
generation:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ spec:
exportedSince:
description: The timestamp from a local clock when the generation
of the object is exported. This field is marked as optional
for compatibility reasons.
for backwards compatibility reasons.
format: date-time
type: string
generation:
Expand Down