-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
constrained_gaussian freezes #261
Comments
Thanks for pointing this out! Indeed, this is trying to create a bounded distribution within For more outlandish values e.g. But i guess for this value of sd (and some nearby), it tries to solve it without success. Quick solves for you
https://en.wikipedia.org/wiki/Logit-normal_distribution Actions
|
266: Small bug fixes in tests r=odunbar a=odunbar <!--- THESE LINES ARE COMMENTED --> ## Purpose <!--- One sentence to describe the purpose of this PR, refer to any linked issues: #14 -- this will link to issue 14 Closes #2 -- this will automatically close issue 2 on PR merge --> - Closes #265 - Addresses #261 (1/2) Leads to a more robust test pipeline and constructor `constrained_gaussian` ## Content <!--- specific tasks that are currently complete - Solution implemented --> - fixes bugs within #265 , - resolves an eks object bug where it would mix prior and final ensemble, and now puts plots in the EKP test subdirectory - adds warning for when users prescribe values in `constrained_gaussian` which will be slow to solve. In these cases a large amount of mass will be concentrated on the boundary. - tightens error of termination to `mu + sig < upper_bound` (before was `mu + 0.7*sig > 1` etc.) likewise for lower bound <!--- Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. --> ---- - [x] I have read and checked the items on the review checklist. Co-authored-by: odunbar <[email protected]>
Closing, now tolerances are sorted, and warning message implemented if solver will struggle. |
PR #266 |
The following code runs, but freezes - I suspect this is due to the choice of parameters, but no warning/error is thrown.
The text was updated successfully, but these errors were encountered: