Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bug fixes in tests #266

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Small bug fixes in tests #266

merged 1 commit into from
Mar 23, 2023

Conversation

odunbar
Copy link
Collaborator

@odunbar odunbar commented Mar 23, 2023

Purpose

Content

  • fixes bugs within Small test bugs #265 ,
  • resolves an eks object bug where it would mix prior and final ensemble, and now puts plots in the EKP test subdirectory
  • adds warning for when users prescribe values in constrained_gaussian which will be slow to solve. In these cases a large amount of mass will be concentrated on the boundary.
  • tightens error of termination to mu + sig < upper_bound (before was mu + 0.7*sig > 1 etc.) likewise for lower bound

  • I have read and checked the items on the review checklist.

increase atol slightly for test subject to random seed errors

warning, and more stringent constrained_gaussian with bounds

format
@odunbar
Copy link
Collaborator Author

odunbar commented Mar 23, 2023

Note - this small change primarily affects unit testing, and there are no user interface changes either, so I shall merge on test success.

@odunbar
Copy link
Collaborator Author

odunbar commented Mar 23, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 23, 2023

Build succeeded:

@bors bors bot merged commit d974079 into main Mar 23, 2023
@bors bors bot deleted the orad/small-bugs-test branch March 23, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small test bugs
1 participant