Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small docs updates #315

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Small docs updates #315

merged 1 commit into from
Jul 19, 2023

Conversation

odunbar
Copy link
Collaborator

@odunbar odunbar commented Jul 17, 2023

Purpose

Closes #311
Closes #308


  • I have read and checked the items on the review checklist.

@odunbar odunbar requested a review from eviatarbach July 18, 2023 17:39
@eviatarbach
Copy link
Contributor

Looks good, but can you please add an example of how to do the EKI loop with a scheduler that terminates early?

@odunbar
Copy link
Collaborator Author

odunbar commented Jul 18, 2023

Oh I see what you are asking for now! Will do.

update docs

add linking

typos fixed in docstrings

address class and subclass

format

typo

ekp loop

termination
Copy link
Contributor

@eviatarbach eviatarbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@odunbar
Copy link
Collaborator Author

odunbar commented Jul 19, 2023

bors r+

@odunbar odunbar closed this Jul 19, 2023
@bors
Copy link
Contributor

bors bot commented Jul 19, 2023

Already running a review

@odunbar odunbar reopened this Jul 19, 2023
@odunbar
Copy link
Collaborator Author

odunbar commented Jul 19, 2023

bors r-

@odunbar
Copy link
Collaborator Author

odunbar commented Jul 19, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 19, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 6e9d3c3 into main Jul 19, 2023
23 checks passed
@bors bors bot deleted the orad/docs-LRS branch July 19, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Learning rate schedulers code snippet in documentation Tighten terminology in docs
2 participants