Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Momentum dynamics validation on the CubedSphere #3306

Open
wants to merge 179 commits into
base: main
Choose a base branch
from

Commits on Oct 4, 2023

  1. Configuration menu
    Copy the full SHA
    53f7fb5 View commit details
    Browse the repository at this point in the history
  2. some cleanup

    navidcy committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    c9aa1b3 View commit details
    Browse the repository at this point in the history
  3. second halo pass

    simone-silvestri committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    58e0145 View commit details
    Browse the repository at this point in the history
  4. change name

    simone-silvestri committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    5d964b2 View commit details
    Browse the repository at this point in the history
  5. weno momentum advection

    navidcy committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    b282ca3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2bdf043 View commit details
    Browse the repository at this point in the history
  7. add second_fill_halo_pass

    navidcy committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    dd35637 View commit details
    Browse the repository at this point in the history
  8. fix second_halo_pass! call

    navidcy committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    d8b83c5 View commit details
    Browse the repository at this point in the history
  9. more verbose name

    navidcy committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    b3f5e24 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Configuration menu
    Copy the full SHA
    aeb39ed View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4b22581 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7eec30c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a1784b4 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2023

  1. Configuration menu
    Copy the full SHA
    4c6f9ee View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Configuration menu
    Copy the full SHA
    c4ca9e9 View commit details
    Browse the repository at this point in the history
  2. visualize vorticity

    navidcy committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    cced0d3 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. code cleanup

    navidcy committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    20ed9c4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    74cc1d3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    99c1e78 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4701920 View commit details
    Browse the repository at this point in the history
  5. update vorticity calculation

    navidcy committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    e5dd568 View commit details
    Browse the repository at this point in the history
  6. add vorticity output

    navidcy committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    d171972 View commit details
    Browse the repository at this point in the history
  7. merge

    navidcy committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    bb2e248 View commit details
    Browse the repository at this point in the history
  8. correct import

    navidcy committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    4292835 View commit details
    Browse the repository at this point in the history
  9. back to previous

    navidcy committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    fde5e2e View commit details
    Browse the repository at this point in the history
  10. plot movies

    navidcy committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    ad15c0e View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2023

  1. Configuration menu
    Copy the full SHA
    746532f View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Configuration menu
    Copy the full SHA
    ae15f9c View commit details
    Browse the repository at this point in the history
  2. Merge branch 'ncc-glw/cubed-sphere-dynamics' of github.com:CliMA/Ocea…

    …nanigans.jl into ncc-glw/cubed-sphere-dynamics
    navidcy committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    87a5d45 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4646a5c View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. 5 Configuration menu
    Copy the full SHA
    0454188 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Configuration menu
    Copy the full SHA
    581fdb9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bb28847 View commit details
    Browse the repository at this point in the history
  3. Fixed a bug and filled more halos

    (a) Fixed a bug in the filling of south-west corner halos of odd panels;
    
    (b) Filled south-east corner halos of odd panels and north-west corner halos of
        even panels.
    siddharthabishnu committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    e6f0d68 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. Filled remaining halos

    Filled the north-west corner halos of odd panels and the south-east corner halos
    of even panels.
    siddharthabishnu committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    e3cb76d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    51a7d96 View commit details
    Browse the repository at this point in the history
  3. Imported change from cubed-sphere-corner-vorticity

    Integrated the modification of the script src/Operators/vorticity_operators.jl
    from commit 55355d9 on branch sb-ncc/cubed-sphere-corner-vorticity.
    siddharthabishnu committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    bb47cf8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8b962b3 View commit details
    Browse the repository at this point in the history
  5. add return

    navidcy committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    9408a01 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    49ef46f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ff5f208 View commit details
    Browse the repository at this point in the history
  8. bit of cleanup

    navidcy committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    689f769 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Configuration menu
    Copy the full SHA
    bea55d6 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. Configuration menu
    Copy the full SHA
    ea1b27a View commit details
    Browse the repository at this point in the history
  2. Merge branch 'ncc-glw/cubed-sphere-dynamics' of github.com:CliMA/Ocea…

    …nanigans.jl into cubed-sphere-dynamics
    siddharthabishnu committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    355587a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cf3f03e View commit details
    Browse the repository at this point in the history
  4. alignment

    navidcy committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    1496f43 View commit details
    Browse the repository at this point in the history
  5. remove duplicate

    navidcy committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    5d669bb View commit details
    Browse the repository at this point in the history
  6. adds test u,v

    navidcy committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    b7483e8 View commit details
    Browse the repository at this point in the history
  7. Merge branch 'ncc-glw/cubed-sphere-dynamics' of github.com:CliMA/Ocea…

    …nanigans.jl into ncc-glw/cubed-sphere-dynamics
    navidcy committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    e7ac069 View commit details
    Browse the repository at this point in the history
  8. sid's changes

    navidcy committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    a6792f6 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Configuration menu
    Copy the full SHA
    b481e98 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ea9e71f View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. Overwrote vorticity computation

    (a) Overwrote vorticity computation in the validation script
        validation/multi_region/cubed_sphere_vorticity.jl
        using only interior points.
    
    (b) The vorticity field looks fine now.
    siddharthabishnu committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    a173d58 View commit details
    Browse the repository at this point in the history
  2. Some cleanup

    siddharthabishnu committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    e07552a View commit details
    Browse the repository at this point in the history
  3. declutter a bit

    navidcy committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    21d8520 View commit details
    Browse the repository at this point in the history
  4. sw/nw -> se/ne

    navidcy committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    ed2cd84 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    66222dc View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Configuration menu
    Copy the full SHA
    b4afa0d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    092f215 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Configuration menu
    Copy the full SHA
    71ebad3 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Comparison with MITgcm

    Compare vorticity values against those generated by MITgcm.
    siddharthabishnu committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    77354c2 View commit details
    Browse the repository at this point in the history
  2. Plot u, v and Δu, Δv w.r.t. MITgcm

    Plot the initial zonal and meridional velocities for Oceananigans and the
    difference w.r.t. their MITgcm counterparts.
    siddharthabishnu committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    0c236de View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. Understand relation between two cubed sphere grids

    Added lines of code to understand how the cubed sphere grid from the solid body
    test case of MITgcm is related to the cubed sphere grid used in Oceananigans.
    After all, it only makes sense to compare the output from two different models
    on the same grid.
    siddharthabishnu committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    49f90a2 View commit details
    Browse the repository at this point in the history
  2. Same grid -> closer MITgcm & Oceananigans outputs

    Executed the MITgcm solid body rotation test case on the grid configuration used
    by Oceananigans, followed by an equivalent test run in Oceananigans for direct
    output comparison. Observed differences in model outputs are now significantly
    reduced, aligning with expectations. Notably, the greatest discrepancies are
    located at the corners of certain cubed sphere panels.
    siddharthabishnu committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    abb577f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    837067d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9435af1 View commit details
    Browse the repository at this point in the history
  5. Minor changes

    siddharthabishnu committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    b6d833d View commit details
    Browse the repository at this point in the history
  6. Merge branch 'ncc-glw/cubed-sphere-dynamics' of github.com:CliMA/Ocea…

    …nanigans.jl into cubed-sphere-dynamics
    siddharthabishnu committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    842189d View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Configuration menu
    Copy the full SHA
    d064b1f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    75c3f28 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'ncc-glw/cubed-sphere-dynamics' of github.com:CliMA/Ocea…

    …nanigans.jl into ncc-glw/cubed-sphere-dynamics
    navidcy committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    ac68144 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Configuration menu
    Copy the full SHA
    c1fe98d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f4b9896 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    121e109 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. Configuration menu
    Copy the full SHA
    b910398 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e25151d View commit details
    Browse the repository at this point in the history
  3. Enhanced solid body rotation test case of MITgcm

    (a) Adjusted initial surface elevation to ensure unit consistency;
    
    (b) Expanded visualization options.
    siddharthabishnu committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    9e561b6 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. Imported changes from ss-sb/implicit-free-surface

    Imported changes from commit 99940c8 of origin/ss-sb/implicit-free-surface.
    siddharthabishnu committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    0bc4142 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Fixed color range bug and renamed functions

    Resolved color range specification bug and renamed functions for clarity in the
    visualization script validation/multi_region/cubed_sphere_visualization.jl.
    siddharthabishnu committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    e358091 View commit details
    Browse the repository at this point in the history
  2. Filled velocity halos in corner regions

    Filled velocity halos in non-existent corner regions of the cubed sphere panels
    for the implicit free surface solver in the script
    src/Models/HydrostaticFreeSurfaceModels/implicit_free_surface.jl.
    siddharthabishnu committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    0c34873 View commit details
    Browse the repository at this point in the history
  3. Plotted the initial state of additional fields

    Plotted the initial velocity fields with and without halos, alongside the
    initial vorticity field with halos. The observed discrepancies along the domain
    boundaries in the vorticity field suggest potential issues with the current
    implementation of velocity halo filling.
    siddharthabishnu committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    9b50474 View commit details
    Browse the repository at this point in the history
  4. Commented out debugging code

    Commented out debug-specific lines of code in
    src/Operators/vorticity_operators.jl.
    These lines, originally introduced for debugging, were inadvertently overriding
    the computed vorticity values, potentially leading to incorrect outcomes.
    siddharthabishnu committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    8bc5508 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. Configuration menu
    Copy the full SHA
    dbcce8f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f73dfd2 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. Configuration menu
    Copy the full SHA
    896fab0 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. Configuration menu
    Copy the full SHA
    8479281 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. Configuration menu
    Copy the full SHA
    fddef06 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Configuration menu
    Copy the full SHA
    6fe1308 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cd7e66c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    50d41be View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Configuration menu
    Copy the full SHA
    b8481e6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ef01019 View commit details
    Browse the repository at this point in the history
  3. First Implementation of Rossby-Haurwitz Test Case

    This commit introduces the initial setup for the Rossby-Haurwitz test case.
    Currently, the simulation has not been executed; this commit only defines the
    initial conditions. This setup is intended for comparison with the earlier
    working version 0.82.0 to verify accurate halo filling and to ensure the initial
    vorticity field values are correct.
    siddharthabishnu committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    b58b12f View commit details
    Browse the repository at this point in the history
  4. Commented out unnecessary lines, used simpler u, v

    This update involves streamlining the code by commenting out unnecessary lines
    and employing more straightforward u and v velocity assignments. Moreover, a
    smaller interior horizontal mesh, consisting of 5x5 cells, is used. The zonal
    velocity (u) is assigned a unique value in each panel using lexicographic
    ordering of the cells. Correspondingly, the meridional velocity (v) at indices
    (i, j) is set to be the negative of u at these indices, i.e. v[i, j] = -u[i, j].
    These changes are primarily implemented to facilitate more effective debugging.
    siddharthabishnu committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    605f18b View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2023

  1. Configuration menu
    Copy the full SHA
    fb34b28 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Fixed Δxᶠᶜᵃ and plotted relevant grid metrics

    (a) Fixed the grid metric Δxᶠᶜᵃ[Nx+1,1-Hy:0] for odd panels;
    (b) Plotted the grid metrics Δxᶠᶜᵃ, Δyᶜᶠᵃ, and Azᶠᶠᵃ for all panels;
    (c) Temporarily set Nx = Ny = 8 and Hx = Hy = 1 for debugging purposes.
    siddharthabishnu committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    5c6b2c5 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Configuration menu
    Copy the full SHA
    a15b0aa View commit details
    Browse the repository at this point in the history
  2. Grid metric changes in Rossby-Haurwitz test case

    Imported grid metric modifications in the Rossby-Haurwitz test case.
    siddharthabishnu committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    3029997 View commit details
    Browse the repository at this point in the history
  3. Ran the Rossby-Haurwitz simulation

    Unfortunately, the numerical solution blows up! So, the
    "run!(simulation)" function call has been commented out for now.
    siddharthabishnu committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    693e12d View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Configuration menu
    Copy the full SHA
    0122a10 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3ee51f6 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Configuration menu
    Copy the full SHA
    deb0d8b View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2023

  1. Configuration menu
    Copy the full SHA
    9d16534 View commit details
    Browse the repository at this point in the history

Commits on Dec 25, 2023

  1. Overwrote additional grid metrics with v0.82.0

    (a) Overwrote the grid metrics Δxᶜᶠᵃ, Δyᶠᶜᵃ, Azᶜᶜᵃ, Azᶠᶜᵃ, and Azᶜᶠᵃ with their
        counterparts from v0.82.0;
    
    (b) The numerical solution for the Rossby-Haurwitz test case remains stable,
        even though the velocity magnitude oscillates between 6.41e+01 and 1.20e+02;
    
    (c) The numerical solution for the solid body rotation test case still blows up!
        This issue is likely linked to the advancement of the free surface using an
        explicit formulation, which differs from the approach used in the equivalent
        MITgcm test case.
    siddharthabishnu committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    78da645 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2024

  1. Overwrote grid metrics from JMC's output file

    (a) Replaced grid metrics Δxᶜᶠᵃ, Δyᶠᶜᵃ, Azᶜᶜᵃ, Azᶠᶜᵃ, and Azᶜᶠᵃ with the
        corresponding values from JMC's output file;
    
    (b) Confirmed that the results are consistent with those in the previous commit,
        where grid metrics were replaced with values from version v0.82.0.
    siddharthabishnu committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    8dd1417 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Configuration menu
    Copy the full SHA
    00cd2b8 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Plotted relative difference of grid metrics

    (a) Added a function to plot the grid metrics with halos;
    
    (b) Plotted the relative difference of the grid metrics (with halos) versus the
        cs32 grid of MITgcm adopted by Ali in Oceananigans v0.82.0.
    siddharthabishnu committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    dac8db2 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2024

  1. Configuration menu
    Copy the full SHA
    f604c6c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3d5ea90 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Added simplified initial velocity for debugging

    This update introduces simplified linear options for the initial velocity field,
    aimed at enhancing the debugging process for halos. The added configurations are
    as follows:
    
    (a) u = c₁ y and v = 0 with c₁ = 1, so that ζ = -c₁ = -1 = constant;
    (b) u = c₁ y and v = c₂ x with c₁ = 1 and c₂ = 2, so that ζ = c₂ - c₁ = 2 - 1
        = 1 = constant.
    
    These options are specifically designed to simplify the analysis of the initial
    vorticity field, ζ,  within both the interior and halo regions of each panel on
    the cubed sphere, with a view to streamlining the debugging process. However,
    the current implementation of these options has been temporarily commented out.
    siddharthabishnu committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    42436d7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    769e357 View commit details
    Browse the repository at this point in the history
  3. Added tests to verify halo vorticity computation

    (a) Added tests to verify the accurate computation of relative vorticity at the
        halo vertices on each panel of the conformal cubed sphere. These tests
        ensure that the vorticity values at these vertices align correctly with
        those in the interior regions of adjacent panels, thus maintaining
        uniformity across the grid.
    
    (b) Identified issues where some tests did not pass as expected. These failing
        tests have been commented out temporarily for further investigation and
        resolution.
    
    (c) Optimized codebase by improving spacing and eliminating redundant lines,
        leading to a more streamlined and efficient code structure.
    siddharthabishnu committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    96e4241 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Configuration menu
    Copy the full SHA
    2c1e39a View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Configuration menu
    Copy the full SHA
    7935d43 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2024

  1. Add Coriolis

    also save SSH field and simplify initial condition setting (so that it would
    work with zero planet rotation)
    jm-c committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    212fc16 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Configuration menu
    Copy the full SHA
    dc6b4ac View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Added new test function for cubed sphere

    (a) Created an alternative test function for the cubed sphere capable of
        handling grids with more than nine cells in each direction on every panel.
        It is designed for compatibility with the cs32 grid, especially after
        incorporating the grid metrics from JMC's output file.
    
    (b) A specific set of 18 tests fail for each test function when using JMC's
        routine for filling the halos.
    siddharthabishnu committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    50d4381 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Updated Rossby-Haurwitz simulation script

    (a) Incorporated the most recent updates from the solid body rotation script
        into the Rossby-Haurwitz wave simulation script;
    
    (b) Turned off momentum advection;
    
    (c) Added horizontal viscosity;
    
    (d) Experimented with smaller time steps;
    
    (e) Observed that the numerical solution becomes unstable, even with
        modifications (b) to (d).
    siddharthabishnu committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    6a000e5 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. fix typo

    jm-c committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    54ba43d View commit details
    Browse the repository at this point in the history
  2. tweaks fill_velocity_halos for high-order scheme

    set some u & v value in halo region to enable to compute vorticity over
    a larger stencil (e.g., if using higher-order vorticity advection).
    jm-c committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    f7cd926 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cff9e5e View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Configuration menu
    Copy the full SHA
    4fbd188 View commit details
    Browse the repository at this point in the history
  2. Deeper ocean + remove global-mean from initial Eta

    - was very shallow before (1.m), change to 1.km and reduce time-step by 2
    - also, for convenience, remove the analytic global-mean from the initial Eta field
    jm-c committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    1bba4ec View commit details
    Browse the repository at this point in the history
  3. Changes to get consistent initial velocity

    Change the ordering so that initial velocity are computed after updating/replacing
    the grid-metric. Previously the initial velocity computed was computed from original
    grid but Oceananigans was running with MITgcm grid-metric, leading to inconsistency.
    jm-c committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    499ffd3 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. 9 Configuration menu
    Copy the full SHA
    35ec029 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Disabled option to employ MITgcm's grid metrics

    (a) Computed and plotted additional grid metrics;
    
    (b) Commented out the manual overwriting of grid metric Δxᶠᶜᵃ[Nx+1,1-Hy:0] for
        odd panels and Δxᶠᶜᵃ[0,Ny+1:Ny+Hy] for even panels;
    
    (c) Reversed option to overwrite grid metrics with their MITgcm counterparts.
    siddharthabishnu committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    bee9fcd View commit details
    Browse the repository at this point in the history
  2. Refactored function and variable names

    (a) Renamed the function fill_halos_of_paired_fields! to
        fill_paired_halo_regions!;
    
    (b) Updated variable names from nInterior to Ninterior and nHalo to Nhalo. This
        modification ensures consistent notation conventions throughout the
        Oceananigans codebase.
    siddharthabishnu committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    8351eec View commit details
    Browse the repository at this point in the history
  3. horizontal_closure = nothing for Rossby-Haurwitz

    Reverted the horizontal closure to "nothing" in the Rossby-Haurwitz simulation
    script.
    siddharthabishnu committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    eb990ac View commit details
    Browse the repository at this point in the history
  4. Fixed a major bug and cleaned up code

    (a) Addressed a major bug by repositioning the function
        fill_paired_halo_regions! from
        src/MultiRegion/multi_region_boundary_conditions.jl to
        src/Models/HydrostaticFreeSurfaceModels/
        update_hydrostatic_free_surface_model_state.jl, since
        include("Models/Models.jl") appears before
        include("MultiRegion/MultiRegion.jl") in Oceananigans.jl;
    
    (b) Cleaned up and compacted code by deleting unnecessary and commented-out
        lines in the following files:
        (i)   src/Models/HydrostaticFreeSurfaceModels/
              update_hydrostatic_free_surface_model_state.jl;
        (ii)  src/MultiRegion/multi_region_cubed_sphere_grid.jl;
        (iii) test/test_multi_region_cubed_sphere.jl;
        (iv)  validation/multi_region/cubed_sphere_dynamics_MITgcm.jl;
        (v)   validation/multi_region/cubed_sphere_rossby_haurwitz.jl.
    siddharthabishnu committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    4c32749 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2024

  1. Bickley jet simulation on the cubed sphere

    A validation script cubed_sphere_bickley_jet.jl is added in the directory
    validation/multi_region, which represents our first attempt at simulating the
    Bickley jet on the cubed sphere.
    siddharthabishnu committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    9b50d93 View commit details
    Browse the repository at this point in the history
  2. Minor modification

    siddharthabishnu committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    9c099ee View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2024

  1. Configuration menu
    Copy the full SHA
    187e631 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bbede50 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Fixed bugs and enhanced Bickley jet test case

    (a) Ensured the function fill_paired_halo_regions! defined in the script
        src/Models/HydrostaticFreeSurfaceModels/update_hydrostatic_free_surface_model_state.jl
        runs smoothly on non-cubed sphere grids without errors;
    (b) Updated the script validation/Bickley_jet/Bickley_jet.jl consisting of the
        Bickley jet test case on a latitude-longitude grid to ensure compatibility
        with the latest Oceananigans codebase;
    (c) Fixed bugs and improved initial conditions and model definitions for the
        Bickley jet test case on a conformal cubed sphere grid.
    siddharthabishnu committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    391789a View commit details
    Browse the repository at this point in the history
  2. remove unneded DataDeps

    navidcy committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    16ba6e4 View commit details
    Browse the repository at this point in the history
  3. nHalo -> Nhalo

    navidcy committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    558d93f View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Clean code with better Bickley jet initialization

    (a) Updated the script validation/bickley_jet/spherical_bickley_jet.jl
        consisting of the Bickley jet test case on a latitude-longitude grid to
        align with the latest Oceananigans codebase;
    (b) Cleaned up the script validation/bickley_jet/bickley_jet.jl consisting of
        the Bickley jet test case on a rectilinear grid by deleting unnecessary
        comments;
    (c) Enhanced the initial conditions and model definitions for the Bickley jet
        test case on a conformal cubed sphere grid. This included adapting the
        initial condition for any cubed sphere radius, utilizing vector-invariant
        momentum advection with horizontal viscosity instead of WENO (which is
        currently inaccurate on the cubed sphere), reducing the Courant number, and
        resolving bugs related to saving the surface elevation and tracer fields.
    siddharthabishnu committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    d85a2d2 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Refined the script multi_region_cubed_sphere.jl

    Streamlined the script multi_region_cubed_sphere.jl in the
    validation/multi_region directory.
    siddharthabishnu committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    6993302 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Configuration menu
    Copy the full SHA
    b478a1d View commit details
    Browse the repository at this point in the history
  2. Renamed files and added information on Imaginocean

    (a) Renamed files containing figures being saved;
    (b) Provided information on how to add the package Imaginocean.jl.
    siddharthabishnu committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    3e19e8a View commit details
    Browse the repository at this point in the history
  3. Added a function to plot fields on the sphere

    Added a function that allows for plotting any field on the sphere either
    directly at the center-center location, or at face-center, center-face, and
    face-face locations after interpolating the field to the center-center location.
    siddharthabishnu committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    e4420c2 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Enhanced Rossby-Haurwitz wave validation script

    (a) Changed the default setting for comparing and replacing grid metrics with
        their MITgcm counterparts (as employed in Oceananigans v0.82.0) to false;
    
    (b) Specified the time step using a Courant Number of 0.2 and the minimum grid
        spacing;
    
    (c) Added surface elevation to the model's output fields;
    
    (d) Uncommented the line responsible for running the simulation;
    
    (e) Plotted relative vorticity and surface elevation on the cubed sphere at
        specific instants of time;
    
    (f) Refactored code and fixed a minor bug by enclosing specific lines within a
        conditional block.
    siddharthabishnu committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    35d1a69 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    010d4ab View commit details
    Browse the repository at this point in the history
  3. Enhanced Bickley jet validation script

    (a) Doubled the time step by increasing the Courant number from 0.1 to 0.2;
    
    (b) Reduced the progress message print interval to every 10 iterations from
        every 300;
    
    (c) Plotted relative vorticity, surface elevation and tracer distribution on the
        cubed sphere at specific instants of time;
    
    (d) Temporarily commented out the generation of animation videos for velocity,
        vorticity, surface elevation, and tracer fields.
    siddharthabishnu committed Feb 29, 2024
    1 Configuration menu
    Copy the full SHA
    9897096 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Improved cubed sphere visualization and bug fix

    (a) Enhanced field visualization on the cubed sphere by consistently applying
        specified colorbar limits across all plots;
    
    (b) Fixed a bug within the visualization function.
    siddharthabishnu committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    941260f View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Configuration menu
    Copy the full SHA
    f86278e View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Configuration menu
    Copy the full SHA
    930b915 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Configuration menu
    Copy the full SHA
    b05b709 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    532df46 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Exported Δxᶜᶜᵃ, Δyᶜᶜᵃ, Δxᶠᶠᵃ, Δyᶠᶠᵃ to jld2 file

    Exported the Oceananigans grid metrics Δxᶜᶜᵃ, Δyᶜᶜᵃ, Δxᶠᶠᵃ, Δyᶠᶠᵃ to the jld2
    file due to the absence of their MITgcm counterparts.
    siddharthabishnu committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    9ec9f54 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Configuration menu
    Copy the full SHA
    1f27841 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Configuration menu
    Copy the full SHA
    b9197c8 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Configuration menu
    Copy the full SHA
    2f29cca View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    01a1afc View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2024

  1. 1 Configuration menu
    Copy the full SHA
    5b8fc15 View commit details
    Browse the repository at this point in the history
  2. Update validation scripts

    Unfortunately, the numerical solution blows up!
    siddharthabishnu committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    07fa4ef View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2024

  1. Configuration menu
    Copy the full SHA
    67e212d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5161be1 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Fix major bug

    siddharthabishnu committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    37e66e2 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Configuration menu
    Copy the full SHA
    1b1ec0a View commit details
    Browse the repository at this point in the history
  2. add comment

    navidcy committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    f3d2a5d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    22d5a37 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c24a936 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Configuration menu
    Copy the full SHA
    42c37cf View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2024

  1. Configuration menu
    Copy the full SHA
    43e970a View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Configuration menu
    Copy the full SHA
    2ea3bbd View commit details
    Browse the repository at this point in the history
  2. Delete replace_horizontal_vector_halos!

    Remove all definitions and instances of the replace_horizontal_vector_halos!
    function.
    siddharthabishnu committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    1f99f74 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2406d2c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    03bdefc View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Configuration menu
    Copy the full SHA
    8c9ca4e View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Configuration menu
    Copy the full SHA
    cdd742d View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Configuration menu
    Copy the full SHA
    0447313 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fa1868c View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Configuration menu
    Copy the full SHA
    6868203 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f66153b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    204933f View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Configuration menu
    Copy the full SHA
    5e1d5a9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    659b1b2 View commit details
    Browse the repository at this point in the history