Momentum dynamics validation on the CubedSphere #3306

navidcy · 2023-10-04T15:35:53Z

navidcy · 2023-10-04T17:23:35Z

it blows up at some point...

cubed_sphere_momentum_dynamics.mp4

I even reduced the tilmestep but not sure if it's that or corner-related artifacts

glwagner · 2023-10-04T18:25:56Z

it blows up at some point...

cubed_sphere_momentum_dynamics.mp4
I even reduced the tilmestep but not sure if it's that or corner-related artifacts

Might help to plot vorticity. Are we using WENO or second order momentum advection?

navidcy · 2023-10-04T19:36:04Z

it blows up at some point...
cubed_sphere_momentum_dynamics.mp4
I even reduced the tilmestep but not sure if it's that or corner-related artifacts

Might help to plot vorticity. Are we using WENO or second order momentum advection?

I didn't prescribe anything so probably 2nd order.

glwagner · 2023-10-04T19:37:07Z

it blows up at some point...
cubed_sphere_momentum_dynamics.mp4
I even reduced the tilmestep but not sure if it's that or corner-related artifacts

Might help to plot vorticity. Are we using WENO or second order momentum advection?

I didn't prescribe anything so probably 2nd order.

Could be the culprit if we don't have viscosity, how about with viscosity or WENO?

validation/multi_region/cubed_sphere_momentum_dynamics.jl

navidcy · 2023-10-05T11:46:38Z

@siddharthabishnu, can you commit the steady-state validation script in this PR from #3302? We were trying to ensure that double halo passing occurs for velocities etc and these are probably also needed for #3302 so let's have both validation scripts in one place so we don't do double job?

siddharthabishnu · 2023-10-05T17:48:03Z

@siddharthabishnu, can you commit the steady-state validation script in this PR from #3302? We were trying to ensure that double halo passing occurs for velocities etc and these are probably also needed for #3302 so let's have both validation scripts in one place so we don't do double job?

Done. 😊

validation/multi_region/cubed_sphere_steady_state.jl

glwagner · 2023-10-07T22:34:21Z

Any progress visualizing vorticity?

navidcy · 2023-10-08T14:52:04Z

Yes. I'll post a script. But it once again demonstrated that halos are not filled properly for face-face fields so I'm trying to deal with #3280 first!

glwagner · 2023-10-10T18:21:38Z

Why do we need to fill halos for face-face?

src/Models/HydrostaticFreeSurfaceModels/pcg_implicit_free_surface_solver.jl

navidcy · 2024-04-17T18:15:10Z

src/Fields/field.jl

+        if size(data)[3] == 1 && first.(axes(data))[3] == grid.Nz + 1 # take ssh into consideration
+            parent_indices = collect(parent_indices)
+            parent_indices[3] = 1:1
+        end


this reads like a hack..

also, what's "ssh" mentioned in the comment?

what if size(data)[2] == 1... then nothing needs to happen?

Yes, it is a temporary hack. I have outlined the issue arising in the absence of this hack in issue #3572 and created PR #3573 to resolve it. In the comment, ssh refers to fields like ssh defined on the xy plane, for which the parent array takes the z-halo into consideration even though it does not exist. In case of a field like the meridional average of a scalar quantity which is defined on the xz plane, the same issue arises without an equivalent hack.

navidcy · 2024-04-18T05:06:48Z

src/TimeSteppers/quasi_adams_bashforth_2.jl

+#- for Forward-Backward+AB2 hack to work:
+    fill_halo_regions!(model.free_surface.η)


what if model doesn't have a free surface?

navidcy · 2024-04-18T05:07:46Z

validation/bickley_jet/bickley_jet.jl

    end
-end
+end


Suggested change

end

end

navidcy · 2024-04-18T05:08:31Z

validation/bickley_jet/spherical_bickley_jet.jl

    end
-end
+end


Suggested change

end

end

validation/multi_region/cubed_sphere_bickley_jet.jl

Remove all definitions and instances of the replace_horizontal_vector_halos! function.

navidcy · 2024-04-22T06:14:40Z

src/Operators/vorticity_operators.jl

+#=
+@inline Γᶠᶠᶜ(i, j, k, grid::OrthogonalSphericalShellGrid, u, v) = 
+    ifelse(on_south_west_corner(i, j, grid) | on_north_west_corner(i, j, grid),
+           Δy_qᶜᶠᶜ(i, j, k, grid, v) - Δx_qᶠᶜᶜ(i, j, k, grid, u) + Δx_qᶠᶜᶜ(i, j-1, k, grid, u), 
+           ifelse(on_south_east_corner(i, j, grid) | on_north_east_corner(i, j, grid),
+                  - Δy_qᶜᶠᶜ(i-1, j, k, grid, v) - Δx_qᶠᶜᶜ(i, j, k, grid, u) + Δx_qᶠᶜᶜ(i, j-1, k, grid, u), 
+                  δxᶠᶜᶜ(i, j, k, grid, Δy_qᶜᶠᶜ, v) - δyᶜᶠᶜ(i, j, k, grid, Δx_qᶠᶜᶜ, u)))
+=#
+


is this old/deprecated code?

Yes. I will delete it.

first try for momentum dynamics on cubedsphere

53f7fb5

navidcy added the cubed sphere 🧊🌎 label Oct 4, 2023

navidcy added this to the 🧊 Global simulations on the cubed sphere milestone Oct 4, 2023

some cleanup

c9aa1b3

simone-silvestri reviewed Oct 4, 2023

View reviewed changes

validation/multi_region/cubed_sphere_momentum_dynamics.jl Outdated Show resolved Hide resolved

simone-silvestri and others added 7 commits October 4, 2023 15:44

second halo pass

58e0145

change name

5d964b2

weno momentum advection

b282ca3

remove passes = 1:2 from fill_halo_regions!

2bdf043

add second_fill_halo_pass

dd35637

fix second_halo_pass! call

d8b83c5

more verbose name

b3f5e24

siddharthabishnu and others added 2 commits October 5, 2023 14:40

Addded steady-state test case from PR #3302

aeb39ed

fix momentum advection scheme

4b22581

glwagner reviewed Oct 5, 2023

View reviewed changes

validation/multi_region/cubed_sphere_steady_state.jl Outdated Show resolved Hide resolved

navidcy and others added 3 commits October 5, 2023 15:58

add script to visualize vorticity

7eec30c

add vertical scheme in momentum advection

a1784b4

Merge branch 'main' into ncc-glw/cubed-sphere-dynamics

4c6f9ee

navidcy mentioned this pull request Oct 10, 2023

Correct vorticity computation at the corners of cubed sphere panels #3325

Closed

navidcy added 2 commits October 11, 2023 17:58

Merge branch 'main' into ncc-glw/cubed-sphere-dynamics

c4ca9e9

visualize vorticity

cced0d3

navidcy commented Apr 17, 2024

View reviewed changes

src/Models/HydrostaticFreeSurfaceModels/pcg_implicit_free_surface_solver.jl Outdated Show resolved Hide resolved

navidcy commented Apr 17, 2024

View reviewed changes

navidcy and others added 2 commits April 17, 2024 21:37

Apply suggestions from code review

22d5a37

Print initial condition and Azᶠᶠᵃ to output file

c24a936

navidcy commented Apr 18, 2024

View reviewed changes

validation/bickley_jet/bickley_jet.jl Outdated

end

end

end

Copy link

Collaborator Author

navidcy Apr 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

end

end

navidcy commented Apr 18, 2024

View reviewed changes

validation/bickley_jet/spherical_bickley_jet.jl Outdated

end

end

end

Copy link

Collaborator Author

navidcy Apr 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

end

end

navidcy commented Apr 18, 2024

View reviewed changes

validation/multi_region/cubed_sphere_bickley_jet.jl Outdated Show resolved Hide resolved

navidcy and others added 2 commits April 18, 2024 08:14

Apply suggestions from code review

42c37cf

Set g = 10, H = 1000, r = 6370e3 for Bickley jet

43e970a

siddharthabishnu force-pushed the ncc-glw/cubed-sphere-dynamics branch from 693d933 to 43e970a Compare April 21, 2024 23:18

Delete cs validation scripts no longer used

2ea3bbd

siddharthabishnu force-pushed the ncc-glw/cubed-sphere-dynamics branch from 28d44f6 to 2ea3bbd Compare April 22, 2024 00:17

siddharthabishnu added 3 commits April 21, 2024 20:28

Delete replace_horizontal_vector_halos!

1f99f74

Remove all definitions and instances of the replace_horizontal_vector_halos! function.

Revert modifications in validation/bickley_jet

2406d2c

Refine cubed sphere Bickley jet validation script

03bdefc

navidcy commented Apr 22, 2024

View reviewed changes

siddharthabishnu added 5 commits April 23, 2024 20:05

Further modify cubed sphere Bickley jet test case

8c9ca4e

Improve visualization of cs validation test cases

cdd742d

Remove MITgcm data visualization functions

0447313

Refine Bickley jet validation script

fa1868c

Compact multiple cubed sphere validation scripts

6868203

siddharthabishnu force-pushed the ncc-glw/cubed-sphere-dynamics branch from 3d58ab7 to 6868203 Compare April 30, 2024 01:39

Rename cs solid body rotation validation script

f66153b

siddharthabishnu force-pushed the ncc-glw/cubed-sphere-dynamics branch from 03aae73 to f66153b Compare April 30, 2024 01:48

Remove commented-out deprecated code

204933f

siddharthabishnu mentioned this pull request Apr 30, 2024

Employ new halo-filling functions to update halos of prognostic variables on the cubed sphere #3570

Draft

siddharthabishnu added 2 commits May 1, 2024 20:00

Fix Rossby-Haurwitz wave initial streamfunction

5e1d5a9

Compact cubed sphere validation scripts

659b1b2

siddharthabishnu force-pushed the ncc-glw/cubed-sphere-dynamics branch from c36d39b to 659b1b2 Compare May 2, 2024 03:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Momentum dynamics validation on the CubedSphere #3306

Momentum dynamics validation on the CubedSphere #3306

navidcy commented Oct 4, 2023 •

edited

Loading

navidcy commented Oct 4, 2023

glwagner commented Oct 4, 2023

navidcy commented Oct 4, 2023

glwagner commented Oct 4, 2023

navidcy commented Oct 5, 2023 •

edited

Loading

siddharthabishnu commented Oct 5, 2023 •

edited

Loading

glwagner commented Oct 7, 2023

navidcy commented Oct 8, 2023

glwagner commented Oct 10, 2023

navidcy Apr 17, 2024 •

edited

Loading

siddharthabishnu May 1, 2024 •

edited

Loading

navidcy Apr 18, 2024

navidcy Apr 18, 2024

navidcy Apr 18, 2024

navidcy Apr 22, 2024

siddharthabishnu Apr 22, 2024

		#- for Forward-Backward+AB2 hack to work:
		fill_halo_regions!(model.free_surface.η)

Momentum dynamics validation on the CubedSphere #3306

Are you sure you want to change the base?

Momentum dynamics validation on the CubedSphere #3306

Conversation

navidcy commented Oct 4, 2023 • edited Loading

navidcy commented Oct 4, 2023

glwagner commented Oct 4, 2023

navidcy commented Oct 4, 2023

glwagner commented Oct 4, 2023

navidcy commented Oct 5, 2023 • edited Loading

siddharthabishnu commented Oct 5, 2023 • edited Loading

glwagner commented Oct 7, 2023

navidcy commented Oct 8, 2023

glwagner commented Oct 10, 2023

navidcy Apr 17, 2024 • edited Loading

Choose a reason for hiding this comment

siddharthabishnu May 1, 2024 • edited Loading

Choose a reason for hiding this comment

navidcy Apr 18, 2024

Choose a reason for hiding this comment

navidcy Apr 18, 2024

Choose a reason for hiding this comment

navidcy Apr 18, 2024

Choose a reason for hiding this comment

navidcy Apr 22, 2024

Choose a reason for hiding this comment

siddharthabishnu Apr 22, 2024

Choose a reason for hiding this comment

navidcy commented Oct 4, 2023 •

edited

Loading

navidcy commented Oct 5, 2023 •

edited

Loading

siddharthabishnu commented Oct 5, 2023 •

edited

Loading

navidcy Apr 17, 2024 •

edited

Loading

siddharthabishnu May 1, 2024 •

edited

Loading