Correct vorticity computation at the corners of cubed sphere panels

[siddharthabishnu]

Closes #1584.

[navidcy]

Suggested change

	scaling = ifelse(on_corner(i, j, grid), convert(FT, 4/3), one(grid))
	scaling = ifelse(on_corner(i, j, grid), convert(FT, 4/3), 1)

[navidcy]

I think we can't move forward with this until we have a working validation script that uses it. So let's wait until #3306 is merged.

[navidcy]

Suggested change

	ifelse(on_south_west_corner(i, j) | on_north_west_corner(i, j, grid),
	ifelse(on_south_west_corner(i, j) | on_north_west_corner(i, j, grid),

[navidcy]

As it is now, it assumes that the ConformalCubedSphereGrid has 1 region per panel. Could we generalize it?

Perhaps these are useful?

Oceananigans.jl/src/MultiRegion/cubed_sphere_partitions.jl

Lines 61 to 83 in b0ba493

	@inline function region_corners(r, p::CubedSpherePartition)
	pᵢ = intra_panel_index_x(r, p)
	pⱼ = intra_panel_index_y(r, p)
	bottom_left = pᵢ == 1 && pⱼ == 1 ? true : false
	bottom_right = pᵢ == p.Rx && pⱼ == 1 ? true : false
	top_left = pᵢ == 1 && pⱼ == p.Ry ? true : false
	top_right = pᵢ == p.Rx && pⱼ == p.Ry ? true : false
	return (; bottom_left, bottom_right, top_left, top_right)
	end
	@inline function region_edge(r, p::CubedSpherePartition)
	pᵢ = intra_panel_index_x(r, p)
	pⱼ = intra_panel_index_y(r, p)
	west = pᵢ == 1 ? true : false
	east = pᵢ == p.Rx ? true : false
	south = pⱼ == 1 ? true : false
	north = pⱼ == p.Ry ? true : false
	return (; west, east, south, north)
	end

[navidcy]

Closing this in favor of #3306