-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct vorticity computation at the corners of cubed sphere panels #3325
Conversation
Corrected the vorticity computed at the corners of the cubed sphere panels by applying the multiplicative factor of (4/3).
src/Operators/vorticity_operators.jl
Outdated
@@ -8,6 +8,20 @@ | |||
""" | |||
@inline ζ₃ᶠᶠᶜ(i, j, k, grid, u, v) = Γᶠᶠᶜ(i, j, k, grid, u, v) / Azᶠᶠᶜ(i, j, k, grid) | |||
|
|||
@inline function ζ₃ᶠᶠᶜ(i, j, k, grid::OrthogonalSphericalShellGrid{FT}, u, v) where FT | |||
scaling = ifelse(on_corner(i, j, grid), convert(FT, 4/3), one(grid)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scaling = ifelse(on_corner(i, j, grid), convert(FT, 4/3), one(grid)) | |
scaling = ifelse(on_corner(i, j, grid), convert(FT, 4/3), 1) |
I think we can't move forward with this until we have a working validation script that uses it. So let's wait until #3306 is merged. |
src/Operators/vorticity_operators.jl
Outdated
|
||
ifelse(on_south_west_corner(i, j) | on_north_west_corner(i, j, grid), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ifelse(on_south_west_corner(i, j) | on_north_west_corner(i, j, grid), | |
ifelse(on_south_west_corner(i, j) | on_north_west_corner(i, j, grid), |
As it is now, it assumes that the Perhaps these are useful? Oceananigans.jl/src/MultiRegion/cubed_sphere_partitions.jl Lines 61 to 83 in b0ba493
|
Closing this in favor of #3306 |
Closes #1584.