Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default scheme for HydrostaticSphericalCoriolis #3500

Merged
merged 8 commits into from
Mar 7, 2024

Conversation

glwagner
Copy link
Member

@glwagner glwagner commented Mar 6, 2024

The default should be ActiveCellEnstrophyConserving according to @simone-silvestri

The default should be `ActiveCellEnstrophyConserving` according to @simone-silvestri
Copy link
Collaborator

@navidcy navidcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you only seem to have changed the docstring function signature.
let's change the description below to agree with the signature...

and also, the constructor at the moment seems to suggests that it's actually the EnergyConserving that is the default, no?

julia> using Oceananigans

julia> HydrostaticSphericalCoriolis()
HydrostaticSphericalCoriolis
├─ rotation rate: 7.29e-05 s⁻¹ = 1.00e+00 Ω_Earth
└─ scheme: EnergyConserving{Float64}

@navidcy navidcy self-requested a review March 6, 2024 16:42
@navidcy
Copy link
Collaborator

navidcy commented Mar 6, 2024

OK, some regression tests break with this change (probably because the data was produced with the default scheme which was different). Also some unit tests. I'll have a look.

@glwagner
Copy link
Member Author

glwagner commented Mar 6, 2024

oh sorry

@navidcy
Copy link
Collaborator

navidcy commented Mar 6, 2024

No worries!
it brings up an issue that regression tests and generation scripts should not rely on default args/kwargs

@navidcy navidcy merged commit 3d9668b into main Mar 7, 2024
48 checks passed
@navidcy navidcy deleted the glw/default-scheme branch March 7, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants