-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default scheme for HydrostaticSphericalCoriolis
#3500
Conversation
The default should be `ActiveCellEnstrophyConserving` according to @simone-silvestri
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you only seem to have changed the docstring function signature.
let's change the description below to agree with the signature...
and also, the constructor at the moment seems to suggests that it's actually the EnergyConserving that is the default, no?
julia> using Oceananigans
julia> HydrostaticSphericalCoriolis()
HydrostaticSphericalCoriolis
├─ rotation rate: 7.29e-05 s⁻¹ = 1.00e+00 Ω_Earth
└─ scheme: EnergyConserving{Float64}
OK, some regression tests break with this change (probably because the data was produced with the default scheme which was different). Also some unit tests. I'll have a look. |
oh sorry |
No worries! |
The default should be
ActiveCellEnstrophyConserving
according to @simone-silvestri