Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default scheme for HydrostaticSphericalCoriolis #3500

Merged
merged 8 commits into from
Mar 7, 2024
Merged

Change default scheme for HydrostaticSphericalCoriolis #3500

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ab1f6cf
Change default scheme for `HydrostaticSphericalCoriolis`
glwagner Mar 6, 2024
622bf6d
change default EnergyConserving -> ActiveCellEnstrophyConserving
navidcy Mar 6, 2024
46f3620
Merge branch 'main' into glw/default-scheme
glwagner Mar 6, 2024
fd990ba
Fix unit test
glwagner Mar 7, 2024
35dc07c
Restore coriolis formulation for regression tests
glwagner Mar 7, 2024
e4e6fed
fix import of ActiveCellEnstrophyConserving
navidcy Mar 7, 2024
0bda941
add rotation_rate kwarg in doc
navidcy Mar 7, 2024
8e54ba9
remove some unnecessary inbounds
navidcy Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Coriolis/hydrostatic_spherical_coriolis.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ end
"""
HydrostaticSphericalCoriolis([FT=Float64;]
rotation_rate = Ω_Earth,
scheme = EnergyConserving())
scheme = ActiveCellEnstrophyConserving())

Return a parameter object for Coriolis forces on a sphere rotating at `rotation_rate`.
By default, `rotation_rate` is assumed to be Earth's.
Expand Down