Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tracer advection in a Single column model #3559

Merged
merged 10 commits into from
Apr 26, 2024

Conversation

simone-silvestri
Copy link
Collaborator

At the moment, tracer advection is nothing in a single-column model, which is consistent with zero velocities and saves computational time.

However, now that we have background velocities and biogeochemical velocities implemented using the same advection scheme as the tracer advection we need to change this behavior so that we can have tracers being advected by background (or sinking) vertical velocities in a single column model.

found by @hengdiliang

@glwagner
Copy link
Member

Hmm true. We can still omit horizontal advection though I guess, but maybe having Flat is enough.

@simone-silvestri
Copy link
Collaborator Author

right, I think Flat assumes that advective_tracer_flux = zero(grid)

@glwagner glwagner merged commit ea87cef into main Apr 26, 2024
46 checks passed
glwagner added a commit that referenced this pull request Apr 26, 2024
@glwagner glwagner mentioned this pull request Apr 26, 2024
@simone-silvestri simone-silvestri deleted the ss-hl/fix-tracer-advection-for-single-column branch April 26, 2024 03:30
navidcy pushed a commit that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants