Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding tracer advection in a Single column model #3559

Merged
merged 10 commits into from
Apr 26, 2024
Merged

Adding tracer advection in a Single column model #3559

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6bac83d
bugfix
simone-silvestri Mar 1, 2024
a077af4
Merge branch 'main' of github.com:CliMA/Oceananigans.jl
simone-silvestri Mar 5, 2024
d0215e9
Merge branch 'main' of github.com:CliMA/Oceananigans.jl
simone-silvestri Mar 6, 2024
b9fbdbc
Merge branch 'main' of github.com:CliMA/Oceananigans.jl
simone-silvestri Mar 8, 2024
fea4bed
Merge branch 'main' of github.com:CliMA/Oceananigans.jl
simone-silvestri Mar 19, 2024
c4bfcd8
Merge branch 'main' of github.com:CliMA/Oceananigans.jl
simone-silvestri Mar 27, 2024
02bfe37
Merge branch 'main' of github.com:CliMA/Oceananigans.jl
simone-silvestri Apr 5, 2024
e1be27f
Merge branch 'main' of github.com:CliMA/Oceananigans.jl
simone-silvestri Apr 12, 2024
fb0ff1a
fix single column model advection
simone-silvestri Apr 24, 2024
906ea56
Merge branch 'main' into ss-hl/fix-tracer-advection-for-single-column
glwagner Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Models/HydrostaticFreeSurfaceModels/single_column_model_mode.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ end
validate_velocity_boundary_conditions(::SingleColumnGrid, velocities) = nothing
validate_velocity_boundary_conditions(::SingleColumnGrid, ::PrescribedVelocityFields) = nothing
validate_momentum_advection(momentum_advection, ::SingleColumnGrid) = nothing
validate_tracer_advection(tracer_advection::AbstractAdvectionScheme, ::SingleColumnGrid) = nothing, NamedTuple()
validate_tracer_advection(tracer_advection::Nothing, ::SingleColumnGrid) = nothing, NamedTuple()
validate_tracer_advection(tracer_advection_tuple::NamedTuple, ::SingleColumnGrid) = CenteredSecondOrder(), tracer_advection_tuple
validate_tracer_advection(tracer_advection::AbstractAdvectionScheme, ::SingleColumnGrid) = tracer_advection, NamedTuple()

compute_w_from_continuity!(velocities, arch, ::SingleColumnGrid; kwargs...) = nothing
compute_w_from_continuity!(::PrescribedVelocityFields, arch, ::SingleColumnGrid; kwargs...) = nothing
Expand Down