Update CUDA packages to get rid of CUDA errors on CPU and use CUDAapi.has_cuda() #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For that one line in the Poisson solver.
Codecov Report
@@ Coverage Diff @@
## master #378 +/- ##
==========================================
- Coverage 78.37% 78.32% -0.06%
==========================================
Files 22 22
Lines 1244 1241 -3
==========================================
- Hits 975 972 -3
Misses 269 269
Continue to review full report at Codecov.
|
vchuravy
reviewed
Aug 29, 2019
| @@ -183,8 +183,6 @@ end | |||
| end | |||
| end | |||
|
|
|||
| @hascuda CuArrays.allowscalar(false) | |||
There was a problem hiding this comment.
You can use @allowscalar to only allow it in a certain location.
There was a problem hiding this comment.
Ah nice, did not know about @allowscalar!
Tried using it from GPUArrays but then noticed we might be performing some scalar operations during model setup so might clean that up in a different PR and finally set allowscalar(false).
This was referenced Aug 29, 2019
Merged
arcavaliere
pushed a commit
to arcavaliere/Oceananigans.jl
that referenced
this pull request
Nov 6, 2019
Update CUDA packages to get rid of CUDA errors on CPU and use CUDAapi.has_cuda() Former-commit-id: c52d0f1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #376
Resolves #295