-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CUDA packages to get rid of CUDA errors on CPU and use CUDAapi.has_cuda() #378
Conversation
For that one line in the Poisson solver.
Codecov Report
@@ Coverage Diff @@
## master #378 +/- ##
==========================================
- Coverage 78.37% 78.32% -0.06%
==========================================
Files 22 22
Lines 1244 1241 -3
==========================================
- Hits 975 972 -3
Misses 269 269
Continue to review full report at Codecov.
|
@@ -183,8 +183,6 @@ end | |||
end | |||
end | |||
|
|||
@hascuda CuArrays.allowscalar(false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use @allowscalar
to only allow it in a certain location.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah nice, did not know about @allowscalar
!
Tried using it from GPUArrays but then noticed we might be performing some scalar operations during model setup so might clean that up in a different PR and finally set allowscalar(false)
.
Update CUDA packages to get rid of CUDA errors on CPU and use CUDAapi.has_cuda() Former-commit-id: c52d0f1
Resolves #376
Resolves #295