-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CUDA packages (attempt 2) #388
Conversation
For that one line in the Poisson solver.
test/test_forcings.jl
Outdated
function time_step_with_forcing_function_const(arch) | ||
const τ = 60 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya.
Should also add some tests with |
Codecov Report
@@ Coverage Diff @@
## master #388 +/- ##
==========================================
- Coverage 70.68% 63.28% -7.41%
==========================================
Files 23 23
Lines 1395 1378 -17
==========================================
- Hits 986 872 -114
- Misses 409 506 +97
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #388 +/- ##
==========================================
- Coverage 70.68% 70.63% -0.05%
==========================================
Files 23 23
Lines 1395 1597 +202
==========================================
+ Hits 986 1128 +142
- Misses 409 469 +60
Continue to review full report at Codecov.
|
I added three forcing function + time-stepping tests to make sure it always works now. CPU and GPU tests passed on Google Cloud so all CI pipelines should pass hopefully. @glwagner Please approve and merge if it looks okay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the example too.
Update CUDA packages (attempt 2) Former-commit-id: e65a74a
The main point of upgrading is to get rid of CUDA errors on the CPU and use
CUDAapi.has_cuda()
which replaces theHAVE_CUDA
variable we've been using.This was originally in PR #378 (this PR is mostly cherry picked commits) but when it was merged @glwagner reported issues with forcing functions on the GPU.
So now I've added a test that makes sure that forcing functions don't crash when used in a CPU or GPU model (one with and one without
const
).