Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breakages to android builds due to toolchain issues #717

Merged
merged 2 commits into from
Apr 21, 2023

Conversation

marktefftech
Copy link
Contributor

See changes in the following files:

These broke our build commands:

  • bazelisk build launcher/android:jazzer_android --config=android_arm
  • bazelisk build src/main/java/com/code_intelligence/jazzer/android:jazzer_standalone_android --config=android_arm

@fmeum
Copy link
Contributor

fmeum commented Apr 21, 2023

Sorry for the breakage, the fixes look good.

To prevent this from happening in the future, would you be interested in adding these invocations to the CI pipeline? The GitHub runners should have Android NDKs/SDKs installed.

@fmeum fmeum merged commit fc67233 into CodeIntelligenceTesting:main Apr 21, 2023
@marktefftech
Copy link
Contributor Author

@fmeum no worries on the breakages.

Going forward I think it's an excellent idea to add the invocations to the CI pipeline. Can you please point me towards where these tests should be added and I will look into prioritizing them?

@fmeum
Copy link
Contributor

fmeum commented Apr 25, 2023

Ideally these tests would just be regular Bazel tests and targets that we could build as part of our existing Linux builds (which are much faster than the macOS and Windows runners).

I started #730 with some refactorings to the way we set Android-related flags, but I don't know enough about Android builds to assess whether these changes are safe. @marktefftech Could you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants