Test Android in CI #730
Test Android in CI #730
Conversation
Replaces the custom `_ANDROID` macro.
This reverts commit 4749267.
The flags should be ignored when building non-Android targets.
|
@marktefftech With regular builds, we use |
|
I'm looking into this and will circle back around shortly. |
|
@fmeum Does PR#734 - |
|
@marktefftech I would still like to get the current PR merged if it doesn't break the Android build. Ideally, we wouldn't need a separate |
| build:android_arm --incompatible_enable_android_toolchain_resolution | ||
| build:android_arm --android_platforms=//:android_arm64 | ||
| build:android_arm --copt=-D_ANDROID | ||
| build:android_arm --java_runtime_version=8 |
There was a problem hiding this comment.
When I tested locally, everything worked except this value still needed to be "=local_jdk" to find the correct toolchain
There was a problem hiding this comment.
Thanks for checking. That probably means that this is blocked onhttps://github.com/bazelbuild/bazel/pull/18262. I will keep it open and we can test it again after that change has landed in Bazel.
There was a problem hiding this comment.
@fmeum Thanks so much for following up with this, we tried many toolchain workarounds for --java_runtime_version flag but couldn't get it to work. Hopefully the above PR will unblock this feature.
In the meantime, we are still hoping to add a basic CI test to ensure the critical targets that we have will continue to build.
Currently we rely heavily on the following two commands:
bazelisk build launcher/android:jazzer_android --config=android_arm
bazelisk build src/main/java/com/code_intelligence/jazzer/android:jazzer_standalone_android --config=android_arm
Can you please offer some guidance on how we can incorporate these commands into the current pipeline? Apologies for the rudimentary question, but I don't have much bazel testing experience yet.
We really just need to make sure that those two commands pass to ensure that Android is in a good state in Jazzer. I think it is important to note that even though the below test commands still execute as expected and the test passes, trying to build these targets individually will still fail:
bazelisk test --config=ci --remote_header=x-buildbuddy-api-key=*** --java_runtime_version=local_jdk_8 --disk_cache=/home/runner/.cache/bazel-disk //launcher/android:jazzer_android --build_tag_filters="-no-linux-jdk8,-no-jdk8" --test_tag_filters="-no-linux-jdk8,-no-jdk8" //...
Thanks in advance, I am happy to implement the test, just need some guidance on where to start.
There was a problem hiding this comment.
@marktefftech Could you try adding --config=android_arm as well as the missing label to
|
Superseded by #807 |
No description provided.