Merge pull request #13 from MingweiSamuel/master

add unref to setTimeout to prevent hanging
Colorfulstan · Jan 4, 2019 · 03ada90 · 03ada90
2 parents 4f4c185 + 154eb8a
commit 03ada90
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 1 deletion.
diff --git a/dist/RateLimit/index.js b/dist/RateLimit/index.js
@@ -154,6 +154,7 @@ class RateLimit {
                 console.log('starting resetTimeout for exceeded limit' + this._seconds * 1000, this.toString());
             }
             this.resetTimeout = setTimeout(() => { this.reset(); }, this._seconds * 1000);
+            this.resetTimeout.unref();
         }
     }
     notifyLimiters() {

diff --git a/dist/RateLimiter/index.js b/dist/RateLimiter/index.js
@@ -274,13 +274,15 @@ class RateLimiter {
         if (this.queue.length !== 0) {
             const factorForEqualRights = Math.floor(Math.random() * 100);
             this.intervalProcessQueue = setInterval(() => { this.processBurstQueue(); }, 1000 + factorForEqualRights);
+            this.intervalProcessQueue.unref();
         }
     }
     refreshSpreadLimiter() {
         this.clearTimeoutAndInterval();
         this.intervalNextSpreadExecution = setInterval(() => {
             this.processSpreadLimitInterval();
         }, this.getSpreadInterval());
+        this.intervalNextSpreadExecution.unref();
     }
     execute(fn, onSuccess, onError) {
         try {

diff --git a/dist/RiotRateLimiter/index.js b/dist/RiotRateLimiter/index.js
@@ -17,7 +17,9 @@ class RiotRateLimiter {
             this.limitersPerPlatformId[platformId] = {};
         }
         if (!this.limitersPerPlatformId[platformId][apiMethod]) {
-            console.log('creating sync rate limimter for ', platformId, apiMethod);
+            if (this.debug) {
+                console.log('creating sync rate limimter for ', platformId, apiMethod);
+            }
             this.limitersPerPlatformId[platformId][apiMethod] = new RateLimiter_1.RateLimiter({
                 limits: [RateLimiter_1.RateLimiter.createSyncRateLimit(this.debug)],
                 strategy: this.strategy,

diff --git a/src/RateLimit/index.ts b/src/RateLimit/index.ts
@@ -222,6 +222,7 @@ export class RateLimit implements Comparable, RateLimitOptions {
       }
       // NOTE: using timeout since interval is not testable for some reason with node-ts and sinon!?
       this.resetTimeout = setTimeout(() => {this.reset()}, this._seconds * 1000)
+      this.resetTimeout.unref()
     }
   }
 

diff --git a/src/RateLimiter/index.ts b/src/RateLimiter/index.ts
@@ -403,6 +403,7 @@ export class RateLimiter {
       // rare case propably
       const factorForEqualRights = Math.floor(Math.random() * 100)
       this.intervalProcessQueue  = setInterval(() => {this.processBurstQueue()}, 1000 + factorForEqualRights)
+      this.intervalProcessQueue.unref()
     }
   }
 
@@ -412,6 +413,7 @@ export class RateLimiter {
     this.intervalNextSpreadExecution = setInterval(() => {
       this.processSpreadLimitInterval()
     }, this.getSpreadInterval())
+    this.intervalNextSpreadExecution.unref()
   }
 
   /**