Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unref to setTimeout to prevent hanging #13

Merged
merged 1 commit into from
Jan 4, 2019

Conversation

MingweiSamuel
Copy link
Contributor

@MingweiSamuel MingweiSamuel commented Dec 19, 2018

Ran the basic mocha tests, may require more testing.

Should fix #7 but haven't actually tested it

@Colorfulstan
Copy link
Owner

Awesome, thanks for figuring that out.
Will merge and publish over the weekend.

@Colorfulstan Colorfulstan merged commit 03ada90 into Colorfulstan:master Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hanging
2 participants