Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current room not greyed out after load #42

Closed
01010100010100100100100101000111 opened this issue Jul 23, 2022 · 1 comment · Fixed by #45
Closed

Current room not greyed out after load #42

01010100010100100100100101000111 opened this issue Jul 23, 2022 · 1 comment · Fixed by #45
Labels
bug Something isn't working

Comments

@01010100010100100100100101000111

Go to any room, save the game

Close the game and restart it,

Load the save, the current room navigation icon will not be greyed out.

@BlackRam-oss BlackRam-oss added the bug Something isn't working label Jul 23, 2022
@BlackRam-oss
Copy link
Collaborator

BlackRam-oss commented Jul 24, 2022

I'm not sure what might be causing the error, but I think it can only be in two places:

Here I add the rooms buttons is in case it is the current room: I set it as selected:
https://github.com/DRincs-Productions/NQTR-toolkit/blob/main/game/tool/nqtr_screens.rpy#L155
cur_room can be nothing.
The line:
selected room == cur_room
It should be improved in: (maybe it also solves the problem)
selected true if cur_room and cur_room.id == room.id else false

Or for some reason cur_room becomes null after loading, caused by one of these functions:
https://github.com/DRincs-Productions/NQTR-toolkit/blob/main/game/tool/core.rpy#L2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants