Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: First import of Compose icons and assets and migrate doc files to ImageVector usage #110

Merged
merged 13 commits into from
Feb 16, 2023
Merged

refactor: First import of Compose icons and assets and migrate doc files to ImageVector usage #110

merged 13 commits into from
Feb 16, 2023

Conversation

GerardPaligot
Copy link
Contributor

Changes description 🧑‍💻

  • First import of Vitamin Compose icons
  • First import of Vitamin Compose assets
  • Migrate documentations and sample code of components to ImageVector usage
  • Use ImageVector internally in Vitamin components

Context 🤔

Will allow to submit automatically new icons and assets from Figma

Checklist ✅

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check compose contract convention. It must follow conventions described here.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

@GerardPaligot GerardPaligot requested review from ManonPolle and a team as code owners February 9, 2023 17:03
@lauthieb lauthieb added enhancement 🚀 New feature or request config 🛠 Related to configuration icons ✨ Related to icons assets 🏞 Related to assets run 💨 and removed config 🛠 Related to configuration labels Feb 9, 2023
@dktbitrise
Copy link

You can download the apk here :

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/a0e8a49f-8ec0-4ab0-9c2f-fd74f7ab6360/artifact/77ae3f3a856d61e6/p/6d646e21d49154975399f5539f48a1f2

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/cc9c6051-8299-43ba-9387-e8b6eb67f39d/artifact/5238c9453402ebd6/p/68a2390dec4fc115b837ead2728b68c3

@GerardPaligot GerardPaligot mentioned this pull request Feb 16, 2023
Merged
9 tasks
ManonPolle
ManonPolle previously approved these changes Feb 16, 2023
View reviewed changes
@dktbitrise
Copy link

You can download the apk here :

@sonarcloud
Copy link

sonarcloud bot commented Feb 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/f9b82f2c-3fe7-46ed-859c-c5b6e4d0566c/artifact/2e681a2dc6c9b68b/p/9678a0a9c0f2c034de0c8b9344b52a11

@ManonPolle ManonPolle merged commit 6c119a2 into Decathlon:main Feb 16, 2023
@GerardPaligot GerardPaligot deleted the refactor/icons-assets branch February 16, 2023 09:45
@ManonPolle ManonPolle added this to the 0.3.0 Version milestone Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManonPolle ManonPolle ManonPolle approved these changes

Assignees

@GerardPaligot GerardPaligot

Labels
assets 🏞 Related to assets enhancement 🚀 New feature or request icons ✨ Related to icons
Projects
Decathlon Design System
Archived in project
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@GerardPaligot @dktbitrise @ManonPolle @lauthieb