Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ratings): Whole number ratings displays as half ratings #156

Merged

Conversation

apauchet
Copy link
Contributor

Changes description πŸ§‘β€πŸ’»

Fix issue about whole number ratings displays as half ratings

Context πŸ€”

Closes #151

Checklist βœ…

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check compose contract convention. It must follow conventions described here.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Screenshots πŸ“Έ

Test with number = 3.0f

Screenshot_20230616_155430

Other info πŸ‘‹

@apauchet apauchet requested review from ManonPolle and a team as code owners June 16, 2023 13:54
@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2023

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dktbitrise
Copy link

@ManonPolle ManonPolle merged commit 6f71eb5 into Decathlon:main Jun 22, 2023
5 checks passed
@ravenfeld
Copy link

@ManonPolle Is it possible to get a version with this fix?

@maxharter
Copy link

Hi @ManonPolle (Maxime, EM at the D_Outdoor team πŸ‘‹ )
Do you have any idea about the delay to have this fix?

thanks a lot,
max
cc @ravenfeld

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(ratings): Whole number ratings displays as half ratings
5 participants