Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ratings): Fix number of stars shown in VitaminRatings composables #176

Merged

Conversation

olivierperez
Copy link
Contributor

Changes description πŸ§‘β€πŸ’»

First I wrote some tests to be sure I'm fixing something.
Then I fixed the algorithm deciding if a star should be Empty, Half or Fill.

Context πŸ€”

Closes #175

Checklist βœ…

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check compose contract convention. It must follow conventions described here.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Screenshots πŸ“Έ

Fixed ratings of 3.0, 3.1, ..., 3.9, 4.0
VitaminRatings

Other info πŸ‘‹

This fix completes another merged fix about whole numbers.

@olivierperez olivierperez requested review from ManonPolle and a team as code owners October 3, 2023 20:40
@CLAassistant
Copy link

CLAassistant commented Oct 3, 2023

CLA assistant check
All committers have signed the CLA.

@sonarcloud
Copy link

sonarcloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@dktbitrise
Copy link

@ManonPolle ManonPolle merged commit 94f29c4 into Decathlon:main Oct 9, 2023
5 checks passed
@olivierperez olivierperez deleted the bugfix/fix_half_star_algorithm branch October 9, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

bug(ratings): Ratings around half value are wrongly choosen
4 participants