Get rid of jQuery dependency #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvet
reviewed
Oct 19, 2017
| @@ -16,9 +16,6 @@ | |||
| }, | |||
| "author": "Developer Express Inc.", | |||
| "license": "MIT", | |||
| "dependencies": { | |||
| "jquery": "^2.0.0 || ^3.0.0" | |||
src/core/nested-option.ts
Outdated
|
|
||
| if (renderData.container) { | ||
| let container = renderData.container.get(0); | ||
| let container = renderData.container.get ? renderData.container.get(0) : renderData.container; |
There was a problem hiding this comment.
Maybe we should extract a helper method with an understandable name?
There was a problem hiding this comment.
Isn't it a temporary solution, that already should be changed to DOM elements?
There was a problem hiding this comment.
No, it is not. You can add the jQuery integration into your application and API of DevExtreme widgets will change
src/core/template.ts
Outdated
| @@ -44,22 +42,31 @@ export class DxTemplateDirective { | |||
| '$implicit': renderData.model, | |||
| index: renderData.index | |||
| }); | |||
| let container = renderData.container.get ? renderData.container.get(0) : renderData.container; | |||
| @@ -71,12 +71,12 @@ describe('DxTextBox value accessor', () => { | |||
| fixture.componentInstance.formControl.disable(); | |||
| fixture.detectChanges(); | |||
|
|
|||
| expect(instance.option('disabled')).toBe(true); | |||
| expect(instance['option']('disabled')).toBe(true); | |||
README.md
Outdated
| @@ -137,6 +139,13 @@ npm start | |||
|
|
|||
| Navigate to [http://127.0.0.1:8875/examples/](http://127.0.0.1:8875/examples/) in the opened browser window. Explore the **examples** folder of this repository for the examples source code. | |||
|
|
|||
| ### <a name="jquery integration"></a>Include jQuery integration ### | |||
| DevExtreme has removed the jQuery dependence in version 17.2. It means that our widgets work without jQuery elements.If you need to use jQuery, you can include the jQuery integration as described below: | |||
Aden-git
reviewed
Oct 19, 2017
| @@ -16,9 +16,6 @@ | |||
| }, | |||
| "author": "Developer Express Inc.", | |||
| "license": "MIT", | |||
| "dependencies": { | |||
| "jquery": "^2.0.0 || ^3.0.0" | |||
| }, | |||
| "peerDependencies": { | |||
| "devextreme": "~17.2.1-0", | |||
There was a problem hiding this comment.
Shouldn't we update a devextreme devDependency?
kvet
reviewed
Oct 19, 2017
src/core/utils.ts
Outdated
| public static getElement(element: any) { | ||
| return element.get ? element.get(0) : element; | ||
| }; | ||
| } |
There was a problem hiding this comment.
Defining a class with static members is not a JavaScript way. Export static methods directly.
ovchinnikov
approved these changes
Oct 19, 2017
kvet
approved these changes
Oct 19, 2017
Aden-git
approved these changes
Oct 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jQuery dependency has been removed #46