-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of jQuery dependency #589
Merged
dxvladislavvolkov
merged 20 commits into
DevExpress:master
from
dxvladislavvolkov:get_rid_of_jq
Oct 23, 2017
Merged
Changes from 17 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
ccc6bef
Get rid of jQuery
dxvladislavvolkov 27cebfc
get rid of jquery from template test and fixes for a domNode
dxvladislavvolkov 8ff13f0
fix for jquery integration
dxvladislavvolkov 348fa9b
Fix tests
dxvladislavvolkov e91d584
Add descriptions in changelog.md and readme,md
dxvladislavvolkov 768fafa
Remove jQuery from package.json
dxvladislavvolkov f73271f
Add the link to 17.1 branch
dxvladislavvolkov c4807d0
Fix text for readme
dxvladislavvolkov 7f421fe
Remove jQuery from systemjs.config
dxvladislavvolkov e3a1d36
Fix tests after update DevExtreme
dxvladislavvolkov 5d8b068
Fix tests
dxvladislavvolkov ad8d4f7
Change the title of changelog
dxvladislavvolkov 0ef73ad
Fix for ie9
dxvladislavvolkov 6644309
Update readme
dxvladislavvolkov c1d8170
Remove jQuery typings from devDependencies
dxvladislavvolkov ff8825c
Update DevExtreme version
dxvladislavvolkov db19013
Add utils and refactoring
dxvladislavvolkov cff7985
Utls refactoring and add hasClass method
dxvladislavvolkov 2a43ce2
Small refactoring
dxvladislavvolkov 4a16fb0
Fix tests using type conversion
dxvladislavvolkov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,17 +16,14 @@ | |
}, | ||
"author": "Developer Express Inc.", | ||
"license": "MIT", | ||
"dependencies": { | ||
"jquery": "^2.0.0 || ^3.0.0" | ||
}, | ||
"peerDependencies": { | ||
"devextreme": "~17.2.1-0", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't we update a |
||
"@angular/core": "^2.4.2 || ^4.0.0 || ^5.0.0-rc.1", | ||
"@angular/common": "^2.4.2 || ^4.0.0 || ^5.0.0-rc.1", | ||
"@angular/forms": "^2.4.2 || ^4.0.0 || ^5.0.0-rc.1" | ||
}, | ||
"devDependencies": { | ||
"devextreme": "~17.2.1-0", | ||
"devextreme": "~17.2.1-pre-17291", | ||
"zone.js": "^0.8.17", | ||
"@angular/core": "^5.0.0-rc.1", | ||
"@angular/common": "^5.0.0-rc.1", | ||
|
@@ -38,7 +35,6 @@ | |
"@angular/compiler-cli": "^5.0.0-rc.1", | ||
"@types/dot": "^1.0.29", | ||
"@types/jasmine": "2.5.38", | ||
"@types/jquery": "ts2.0", | ||
"@types/mkdirp": "^0.3.29", | ||
"@types/node": "^6.0.51", | ||
"@types/yargs": "^6.3.2", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
export class Utils { | ||
public static addClass(element: any, name: string) { | ||
if (element.nodeType === 1) { | ||
if (element.classList) { | ||
element.classList.add(name); | ||
} else { | ||
element.className = element.className ? element.className + ' ' + name : name; | ||
} | ||
} | ||
}; | ||
|
||
public static getElement(element: any) { | ||
return element.get ? element.get(0) : element; | ||
}; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Defining a class with static members is not a JavaScript way. Export static methods directly. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about types for jquery?