Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #35

Merged
merged 6 commits into from
Nov 7, 2023
Merged

Improvements #35

merged 6 commits into from
Nov 7, 2023

Conversation

amerkoleci
Copy link
Contributor

@MrBrixican
Copy link
Contributor

We should probably be using double as glClearDepth uses double not float, and our depth buffers have 24 bits of precision, more than the 16 max we could specify via float.

@amerkoleci
Copy link
Contributor Author

We should probably be using double as glClearDepth uses double not float, and our depth buffers have 24 bits of precision, more than the 16 max we could specify via float.

Mmm, d3d11 for example uses float

@MrBrixican
Copy link
Contributor

You know what, I screwed up on the math. floats have 32 bits, not 16. Ignore what I said, floats are fine.

@amerkoleci
Copy link
Contributor Author

You know what, I screwed up on the math. floats have 32 bits, not 16. Ignore what I said, floats are fine.

Saw that, don't worry :)

@NoelFB
Copy link
Collaborator

NoelFB commented Nov 7, 2023

Looks good, thanks! :D

@NoelFB NoelFB merged commit 023c72e into FosterFramework:main Nov 7, 2023
3 of 4 checks passed
@amerkoleci amerkoleci deleted the improvements branch November 7, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graphics.Clear depth should be double, not int
3 participants