Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Add polls to existing discussions #16

Closed
eddiewebb opened this issue Jul 1, 2020 · 4 comments
Closed

Enhancement: Add polls to existing discussions #16

eddiewebb opened this issue Jul 1, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@eddiewebb
Copy link

I have 3 times now forgot to create the poll on creation, and had to delete the old thread and create a new one.

I searched the flarum board and found several other users asking for this as well.

https://discuss.flarum.org/d/20586-friendsofflarum-polls/50
https://discuss.flarum.org/d/20586-friendsofflarum-polls/58
https://discuss.flarum.org/d/20586-friendsofflarum-polls/84
https://discuss.flarum.org/d/20586-friendsofflarum-polls/81

Thought I would aggregate and record interest.
@Ralkage
Copy link
Contributor

Ralkage commented Jul 2, 2020 •
edited
Loading

Thank you for submitting this feature request.

As soon as we're able to, we'll look into this request and give a possible timeline towards implementation if the team decides to pursue this :)

@Ralkage Ralkage added enhancement New feature or request good first issue Good for newcomers and removed good first issue Good for newcomers labels Jul 2, 2020
@arthuragone
Copy link

This looks like a top notch feature

@deteh
Copy link

deteh commented Feb 20, 2023

This sounds like a really good improvement.

dsevillamartin added a commit that referenced this issue Jul 6, 2023
@dsevillamartin
Create endpoint for new poll to add to existing post
5e66e80 
Refs #67, #16

* Behavior & logic on post/discussion creation is the same - code is mostly shared
* Prevent editing poll if user cannot edit post
* Add policy to post for starting poll on said post - user must be able to edit post & start polls in discussion (tag scoped)
@dsevillamartin dsevillamartin mentioned this issue Jul 6, 2023
Merged
2 tasks
dsevillamartin added a commit that referenced this issue Jul 9, 2023
@dsevillamartin
Create endpoint for new poll to add to existing post
2aba070 
Refs #67, #16

* Behavior & logic on post/discussion creation is the same - code is mostly shared
* Prevent editing poll if user cannot edit post
* Add policy to post for starting poll on said post - user must be able to edit post & start polls in discussion (tag scoped)
dsevillamartin added a commit that referenced this issue Jul 12, 2023
@dsevillamartin
Create endpoint for new poll to add to existing post
0c93efa 
Refs #67, #16

* Behavior & logic on post/discussion creation is the same - code is mostly shared
* Prevent editing poll if user cannot edit post
* Add policy to post for starting poll on said post - user must be able to edit post & start polls in discussion (tag scoped)
dsevillamartin added a commit that referenced this issue Jul 12, 2023
@dsevillamartin
More features & breaking v2 changes (#74)
533b54b 
* Move voters button next to heading & fix no permission error after poll ends

* Create endpoint for new poll to add to existing post (refs #67, #16)

* Drop 'newPollVote' websocket message (fixes #38)

* Remove deprecated single vote API endpoint

* Drop ReFlar/polls database compatibility

* Rename 'canSeeVotes' to 'canseeVoters'

* Don't show if post is hidden unless revealing content, adjust some styling

* Add visibility scoping to polls, prohibit actions if user cannot view post

* Reduce quirkiness with poll option tooltips & disable voting while voting

* Move 'canStartPolls' global attribute to ForumSerializer

* Don't check for existence of post when poll is created during post creation

* Fix check for being able to start poll in non-existing post

* Fix frontend not allowing clearing existing poll's end date

* Separate edit permission into own polls & polls in own posts
@dsevillamartin
Copy link
Member

Fixed in #74.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Ralkage @eddiewebb @dsevillamartin @deteh @arthuragone